Repository navigation
fix(computer-use): observe an app's floating and panel-level windows - #10188
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] This PR appears safe to merge; no actionable issues were found. SummaryThe helper now includes an app’s floating and panel-level windows below the Dock level, while keeping the existing Accessibility matching and input checks.
Reviews (1) · Last reviewed commit: "fix(computer-use): observe an app's floa..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windowsFornow keeps every level below the Dock (normal, floating, modal panel, utility). Menus, status items and overlays stay excluded, and a window still has to match an Accessibility window to be listedType of Change
Testing
AXWindowwhose window-list entry is at layer 8, and input into it failed exactly as in the recordingswiftc -target arm64-apple-macosx14.0; no TS changes, so lint/audits are unaffectedChecklist
test-auditauthoring gate)