Repository navigation
fix(integrations): hide retired hugging face providers, encode posthog ids, and trim zep final ids - #10190
Merged
Conversation
…g ids, and trim zep final ids
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] This PR appears safe to merge. SummaryThis PR cleans up integration choices, makes PostHog request paths safer, restores Zep’s trailing-space behavior, and fixes the Desktop settings order.
No actionable issues found. waleedlatif1 explicitly deferred billing for cancelled hosted-key Firecrawl jobs because it needs new executor and billing support; this PR leaves that behavior unchanged. Reviews (1) · Last reviewed commit: "fix(integrations): hide retired hugging ..." · Reviewed by Greptile |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release cleanups for Hugging Face, PostHog, Zep and the Desktop settings nav.
@huggingface/inferenceclient (getProviderHelper). Fal AI and Replicate register noconversationaltask there, and Hyperbolic, Nebius and SambaNova are not registered at all, so none of them has a chat-completions route. Those five options are nowhidden: true. They are not removed, so saved workflows that store one still validate, and the request a saved block sends is unchanged.safeUrlPathSegmentvia a smallpostHogPathSegmenthelper. Numeric IDs, UUIDs and the@currentalias produce byte-identical URLs to production (@is kept literal).%20. Those two call sites trim trailing whitespace again, so they match production. Mid-path IDs are unchanged.Left for a decision: Firecrawl cancelled runs on the hosted key
A hosted-key Firecrawl crawl, batch scrape, agent or extract cancelled mid-poll returns
success: false, and hosted cost is applied only to successful results, so credits Firecrawl already used are not billed (Extract has no cancel endpoint, so its job keeps running). There is no existing mechanism that bills this cleanly:applyHostedKeyCostToResult) runs only on successful results, andToolHostingConfighas no option to bill a failed one.output.cost. Only the Function and Pi handlers attach a trusted cost to the thrown error, andnormalizeTrustedExecutionCostneedsinput/output/total, which the hosted cost shape does not have.recordServiceMeteringFailureonly records inside a Copilot service-meter scope. In workflow runs it does nothing.creditsUsed(Firecrawl v2 OpenAPI). Extract status carries onlytokensUsed.Billing these runs needs new plumbing in the executor and hosted-key path, so it is left out of this PR.
Release notes
Hugging Face
PostHog
?,#or a space reaches the right resource instead of breaking the URL, and an ID that is.,..or contains/is rejected with a clear error instead of addressing a different endpoint. Numeric IDs, UUIDs and@currentsend the same request as before.Zep