Skip to content

feat(search): import large permission snapshots in bounded parts - #10191

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/gitlab-large-permission-imports
Nov 19, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/gitlab-large-permission-imports

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add bounded, revision-checked permission imports for large GitLab CSV pairs, with atomic activation and durable cleanup. Existing inline uploads remain compatible.
  • Update the exporter and CI uploader, and add a copyable Source ID in connection settings.

Type of Change

  • Enhancement

Testing

All CI checks passed, including the full unit suites, docs acceptance, PostgreSQL migration/authorization/cleanup tests, and HTTP acceptance. The large-import test persisted 500,000 identities and 3,000,000 grants through 700 HTTP parts, verified atomic activation and revocation, and confirmed inline replacement still works. CI reports

Local lint, all 64 audits, workspace type checks, migration safety/schema sync, 26 GitLab tests, 50 focused CLI tests, 34 exporter checks, and 12 uploader HTTPS checks passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 19, 2026 12:10am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Critical impact] The changes since the previous review appear safe to merge; no new blocking issues were found.

Summary

Adds bounded GitLab permission uploads that keep existing access unchanged until the complete snapshot is published.

  • Large GitLab permission snapshots can be staged and activated as one revision-checked update.
  • CI jobs can upload larger GitLab permission snapshots in bounded parts.
  • Connection settings show a Source ID that admins can copy.

No new actionable issues found in the changes since the previous review.

Reviews (3) · Last reviewed commit: "fix(search): reject exhausted permission..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 46 files

Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/docs/openapi-v2-resources.json Resolved
@waleedlatif1
waleedlatif1 force-pushed the codex/gitlab-large-permission-imports branch from 5a5899a to ea0fb42 Compare November 18, 2026 23:55
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 50 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 50 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 708e4b2 into staging Nov 19, 2026
65 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/gitlab-large-permission-imports branch November 19, 2026 00:20

This branch was successfully deployed

1 active deployment
Preview — 9bc8b931 Deployed Nov 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant