Repository navigation
improvement(mothership): log each client tool's outcome and wait time - #10194
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Low impact] This PR appears safe to merge; no actionable issues were found. SummaryAdds outcome and elapsed-wait logging for tools run by the browser or desktop.
No actionable issues found. Reviews (1) · Last reviewed commit: "improvement(mothership): log each client..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_workflow,run_block, desktop reads) only had the routing line, so their outcome and wait were invisible in logstoolName,outcome(success,error,cancelled, ..., ormissingon a timeout) anddurationMsType of Change
Testing
lib/mothership/request/handlerstests: 80/80 passingChecklist
test-auditauthoring gate)