Skip to content

improvement(mothership): log each client tool's outcome and wait time - #10194

Merged
waleedlatif1 merged 2 commits into
stagingfrom
improvement/mothership-tool-call-log
Nov 19, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
improvement/mothership-tool-call-log

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Server-run tools already log "Tool execution succeeded/failed". Tools the browser or desktop runs (run_workflow, run_block, desktop reads) only had the routing line, so their outcome and wait were invisible in logs
  • Adds one "Client tool execution settled" line when the client wait ends, with toolName, outcome (success, error, cancelled, ..., or missing on a timeout) and durationMs
  • A workflow call the server took over is still logged by the server executor, as before

Type of Change

  • Improvement

Testing

  • lib/mothership/request/handlers tests: 80/80 passing
  • biome on the changed file; type-check and audits run in CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 19, 2026 12:58am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge; no actionable issues were found.

Summary

Adds outcome and elapsed-wait logging for tools run by the browser or desktop.

  • Client tool waits now log their outcome and duration.

No actionable issues found.

Reviews (1) · Last reviewed commit: "improvement(mothership): log each client..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 5858006 into staging Nov 19, 2026
56 of 57 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/mothership-tool-call-log branch November 19, 2026 01:01

This branch was previously deployed

1 inactive deployment
Preview — 14cadaff Deployed Nov 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant