Repository navigation
feat(computer-use): add typed reminder, event and contact app commands behind a desktop capability - #10196
Draft
waleedlatif1 wants to merge 2 commits into
Draft
feat(computer-use): add typed reminder, event and contact app commands behind a desktop capability#10196waleedlatif1 wants to merge 2 commits into
waleedlatif1 wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app_commandmethod that runs allowlisted commands through EventKit, never Apple Events or scripts, so scripting apps stay blocked (fix(computer-use): refuse Script Editor, Automator and Shortcuts, which run shell commands outside the Terminal control #9990). It covers Reminders (list_reminder_lists,create_reminder), Calendar (list_calendars,create_event, with timed or all-day events up to 31 days and an optional alert) and Contacts (list_contact_groups,create_contact_group, which returns an existing group of the same name, andcreate_contact, with up to 5 emails and phones and an optional group). Dates must be date-only or carry an explicit offset. Without the matching access a command fails with*_permission_requiredbefore touching anything. Status reports all three accesses without prompting.user_declined/not_started. Commands skip snapshot handling and the post-action observation.computerUseAppCommandsonly by shells that support it, and only sent when computer use itself is allowed for the chat. The authorize route, transport and client tool executor accept the extended schema. The result message tells the model that a created item exists and must not be repeated.personal-information.calendarsand.addressbookentitlements for the hardened runtime.Draft: a prototype paired with mothership#983, which must land first (contract sync). Benchmarks show Reminders, Calendar and Contacts data entry costs about 18 GUI calls per item, and 60 to 130 calls per task. I will compare call counts on the macOS benchmark before taking this out of draft.
Type of Change
Testing
service.test.ts: every write command (reminder, event, contact group, contact) asks for confirmation; a declined create never reaches the helper; a confirmed create runs once with no observation; app denial stops before the confirmation; list reads need no confirmation. Desktopipc.test.tsand the desktop typecheck pass.payload.test.ts: app commands are offered only where computer use is allowed. I confirmed this test fails with the guard removed.Checklist
test-auditauthoring gate)Companion: simstudioai/mothership#983