Repository navigation
refactor(resources): converge Files onto the shared drag hook and batch bulk authorization - #6748
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
externalDropoption on the shared hook and the copy is gone — folder rows highlight and spring open for an OS file drag exactly as for a move, while the body and breadcrumb decline so the page-level upload overlay owns those regionsActiveDropTargetunion, so exactly one affordance is armed by construction instead of by hand-clearing the other twodragoverno longer re-renders the list on every eventdrag-payload.tsdocuments is true againuseSpringNavigation, the only layer that can express it--surface-active;--surface-4is the button-base token and is lighter than hover in light mode, so the strongest row state painted the faintest fillType of Change
Testing
bun run type-check,bun run check:audits(27/27), and 4013 tests pass.New coverage for the drag lifecycle: re-entering a folder through the breadcrumb, refusing to re-open the folder already on screen, cancelling a pending open when the drag moves onto the current folder, one-hop return to origin after a multi-level round trip, staying put when the round trip ends in a drop, and the next drag taking a fresh origin. Plus unit tests for the permission memo, including key separation and re-query after a rejection.
Not browser-tested — the convergence changes which code path Files runs, so the drag interactions are worth a manual pass.
Checklist