Repository navigation
fix(og): put the landing model and integration cards on the brandbook template - #6913
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #6907, which moved the shared-file card onto the brandbook cover template. The five models/integrations cards were the last ones still rendering the retired design — dark
#121212field, the old green square-icon logo, Geist — so a shared/integrations/slacklink and a shared file unfurled as two different products.opengraph-image.tsxroutes (models index, provider, model, integrations index, integration) tocreateCoverOgImage.app/(landing)/og-utils.tsxand its test, theog-sim-logocomponent, and the two Geist TTFs — nothing else referenced any of them. Also droppedMAX_CONTEXT_WINDOW, which existed only to feed a pill row.COVER_OG_SIZErather than restating it.Captions now wrap to two lines (
COVER_MAX_CAPTION_LINES), ellipsized past that. A one-line caption was fine for shared-file provenance but would have gutted a catalog description.What the template drops
The reference template is a title and a caption, so the
eyebrow, the pill row, and thedomainLabelhave no slot. Rather than re-add them and re-fork the design we just unified, the counts the pills carried are folded into the two index captions — "Browse N models from N providers…", "Connect N apps and services and N+ tools…". The per-item cards already named their provider and pricing in the caption. Happy to reinstate a pill row on the template if the density is worth it, but that's a design call rather than a bug fix.One fix in the shared renderer
translateY(14px)moves the title visually but not in flow, so the title descended into the caption's gap and the two crowded. The caption'smarginTopnow adds the nudge back, restoring the intended optical gap. Because the footer is bottom-anchored this lifts the title rather than pushing the caption into the bottom padding — verified against rendered output, and it improves the shared-file card too.Type of Change
Testing
Rendered every card shape and compared against a library cover. Layout tests extended for caption wrapping and truncation, and they measure the font independently of the renderer, so an estimator regression turns them red. Confirmed all five routes omit
openGraph.imagesso the file-based card is what actually ships — Next skips the file-based image whenever a page declares that key, including asundefined.bun run lint,bun run check:audits(32/32),check-block-registry,tsc --noEmit, and 16 tests pass.Checklist