Skip to content

App builds call the harness's __rt.reg for every binding; the registry is never pruned and grows with each mount (CP-4c) #80

Open

Description

@ethan-huo

Every module app() compiles (the Vite front end, rxc app) calls the conformance harness's __rt.reg(name, …) for every binding. The runtime's reg appends to a registry that nothing ever removes from, so an app that keeps mounting components grows that registry without bound.

Versions: @reactivescript/compiler, @reactivescript/runtime 0.3.1; solid-js / @solidjs/web 2.0.0-rc.21; @solidjs/vite-plugin 3.0.0-next.57.

Repro

main.rx:

component Row({ label }: { label: string }) {
  upper = label + "!"
  <li>{upper}</li>
}

export default component App() {
  source items := ["a", "b", "c"]
  <ul>{for item in items { <Row label={item} /> }}</ul>
}

Compiled with app("main.rx", "dom"), Row contains:

__rt.reg("label", { get: v$label });
__rt.reg("upper", { get: v$upper });

Mounting it with createApp from @reactivescript/runtime/web, counting calls to app.reg, and replacing items with three new strings 1000 times (app.dset("items", [], [...]) then flush()):

after mount: rows 3 reg calls 7
after 1000 replacements: rows 3 reg calls 6007

The DOM holds three rows at the end, but the registry holds 6007 entries. Each entry keeps the disposed rows' accessors (and through them their nodes) reachable for the life of the app.

Expected

spec/11-compiler.md CP-4c: reg, lookup, dget, dset, api, jsError, B.fetch/B.fail, … are the harness's, and "Compiled code calls them only in a conformance build — the compiler's option for running scenarios/". The app build (app(), the product path the Vite plugin uses) should not emit __rt.reg, or the module-level reg for imports. If a registry stays in the runtime for some other reason, an entry should be removed when its owner is disposed.

Cause

  • The crate has no conformance switch. compile_linked (compiler/src/emit.rs:194) takes only by_source, and the reg statements are emitted unconditionally: compiler/src/emit.rs:696, :739, :761, and fn reg at :893-899, which every source, equation and prop goes through.
  • ref/compile/rt-web.ts:154 (published dist/web.js reg) only ever does l.push(e). There is no onCleanup and no removal.

Related: #74 is another case of harness-only code (the scenario prelude __B.*) reaching app builds.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions