Skip to content

ref: build Solid from main, now that next is gone - #87

Merged
ryansolid merged 3 commits into
solidjs:mainfrom
oddcelot:solid-next-main
Nov 20, 2026
Merged

ryansolid merged 3 commits into
solidjs:mainfrom
oddcelot:solid-next-main

Conversation

@oddcelot

Copy link
Copy Markdown
Contributor

Hi! 👋 While working on editor tooling in my fork, I noticed the editor workflow failing at the Solid build step:

fatal: Remote branch next not found in upstream origin

With the new Solid release a few days ago, next was merged into main and the branch was deleted. So ref/scripts/solid-next.sh can't clone it anymore, and the job fails for every PR that touches tooling/ or compiler/.

The fix

The pinned commit in ref/SOLID_NEXT (2105ffb) is on Solid's main, so:

  • The script clones main instead of next. Solid is still built at the same commit as before.

  • The pin is fetched by its hash. It builds whichever branch the commit is on, so a branch going away can't break the checkout again.

  • A new SOLID_BRANCH variable (default main) picks the branch a new checkout starts on and --latest follows. If a new next shows up, you can run:

    SOLID_BRANCH=next sh ref/scripts/solid-next.sh --latest

I also updated the docs that say which branch to build (README.md, CONTRIBUTING.md, ref/README.md). I left the eval write-ups alone, since they describe past runs.

How I tested it

  • A fresh clone of main checks out the pinned commit.
  • A clone that doesn't have the pinned commit fetches it by its hash.
  • --latest with SOLID_BRANCH pins that branch's current commit.
  • The editor workflow passes on this branch in my fork (run).

Happy to change anything. Thanks for taking a look!

solidjs/solid deleted its next branch, so cloning it fails in CI. The pinned
commit (ref/SOLID_NEXT) is on main, so the build is unchanged.
The pin builds whichever branch it is on, so a branch that goes away no longer
breaks the checkout. SOLID_BRANCH (default main) is the branch a new checkout
starts on and --latest follows.
@ryansolid
ryansolid merged commit 2f3419d into solidjs:main Nov 20, 2026
2 checks passed
ryansolid pushed a commit that referenced this pull request Nov 20, 2026
solid-next.sh takes #87's version (fetch the pin by hash, SOLID_BRANCH); the pin stays 99db9bce4.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWLtkg281f1NkGEDjCt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants