Repository navigation
Conversation
|
|
👷 Deploy request for solid-docs-v2 pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description(required)
The
StartOptionsreference listsrenderMode?: "stream" | "async"in its type but has no section for it, unlike the options around it. This adds one, based on therenderModesection of the@solidjs/vite-plugin3.0.1 README:"stream"and"async"each send, and that a client without JavaScript sees theLoadingfallbacks under"stream";"async"(first byte waits for the slowest boundary, whole page buffered,deferStreammoot, a mid-renderLocationbecomes a real3xx);event.renderModein middleware, thehandleRequest(request, { renderMode })host option, and their precedence;Checked:
prettier --check,pnpm lint:tone(0 errors),pnpm check:types. Rendered the page withvite dev: the section shows withid="rendermode"and the#middlewarelink resolves.Related issues & labels
Loadingfallbacks into static HTML unlessrenderMode: "async"is set #1713 (which notes this reference page has norenderModesection) and docs: use renderMode async in the prerender recipe #1714🤖 Generated with Claude Code