Skip to content

Getting active experiment value equal to value of active experiments finished key value(i.e. true, once the experiment is finished) ) #580

Closed

Description

@aakashtiwari

Once the experiment is finished, calling active_experiments is returning the value of experiment as 'true'(instead of enabled or disabled) when the version count exceeds 9.

The issue is with

def key_without_version(key)
key.split(/:\d(?!:)/)[0]
end

if we pass 'exp:1' as key it is returning 'exp'
if we pass 'exp:1:finished' as key it is returning 'exp:1:finished'
if we pass 'exp:11' as key it is returning 'exp'

but

if we pass 'exp:11:finished' as key it is returning 'exp' where as 'exp:11:finished' is expected.
This is why it overriding the value of experiment with experiment's finished key value when we fetch active experiments.

Activity

  1. aakashtiwari commented on Aug 21, 2019

    @aakashtiwari
    Author

    @andrehjr I had raised the PR for the above bug. Please review.
    https://github.com/splitrb/split/pull/581
    Also, I am open to suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions