You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
When split cookie is a valid, json encoded String, a NoMethodError is raised #695
Hi @knarewski! Thanks for the issue and the repro!
Please send a PR 🎉 We should also protect it against other types. if JSON.parse returns anything other than a Hash, split wouldn't know how to handle it.
Hi @andrehjr ! Thank you for such a swift response 🚀 ! I prepared a fix, but it's blocked by an unrelated CI failure. I'm happy to submit a PR once the CI fix is merged: #696
Activity
andrehjr commentedon Sep 8, 2022
Hi @knarewski! Thanks for the issue and the repro!
Please send a PR 🎉 We should also protect it against other types. if JSON.parse returns anything other than a Hash, split wouldn't know how to handle it.
An integer would also break:
If I remember correctly, this issue should happens with json >= 2.0. Because the behavior of JSON.parse changed.
knarewski commentedon Sep 12, 2022
Hi @andrehjr ! Thank you for such a swift response 🚀 ! I prepared a fix, but it's blocked by an unrelated CI failure. I'm happy to submit a PR once the CI fix is merged: #696