You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Deprecation warning by using redis.sadd with Redis 4.8.0 #700
As the returned value from redis.sadd is not used, a fix could be to follow the suggestion from the warning and change add_to_set to use redis.sadd? instead of redis.sadd if available:
Activity
andrehjr commentedon Jan 12, 2023
I think that's fair. Do you want to open an PR?
sadd?is only available after redis 4.8.. and we're still on 4.2.martingregoire commentedon Jan 13, 2023
Yes, I'll try to take a look at the tests and then create a PR.
Updating the Redis dependency to 4.8 might be too much, right? That's why I thought about adding the "use
sadd?if available" logic.andrehjr commentedon Jan 13, 2023
For now, checking if sadd? is available is good enough.
As 4.8 was released in August 22, bumping the dependency might be too soon. But it will happen at some point
Fix deprecation warning with Redis 4.8.0
martingregoire commentedon Jan 13, 2023
Please have a look at the PR if your time permits. 🔧
andrehjr commentedon Jul 25, 2023
Closed by #701