Skip to content

[TGL][SDW] runtime PM always in active on TGL chromebook/SDW mode #2162

Closed

Description

@YvonneYang2

Describe the bug
runtime PM always in active on TGL chromebook/SDW mode.

To Reproduce
Check runtime PM status when sof is idle for more than 3 seconds.

$cat /sys/bus/pci/devices/0000\:00\:1f.3/power/runtime_status

Reproduction Rate
10/10

Expected behavior
runtime PM will be suspended after sof is idle for more than 3 seconds.

Environment
Kernel:https://github.com/thesofproject/linux/commits/topic/sof-dev commit:5cb79ee6f
Revert regression on USB-C 6a7c533
Revert regression on PINCTRL cd0a323+ #2062 + hack commit 6769df9
FW:: https://github.com/thesofproject/sof/tree/tgl-006-drop-stable plus thesofproject/sof#3006
TPLG: sof-tgl-sdw-max98373-rt5682-4ch.tplg rename to sof-tgl-sdw-max98373-rt5682.tplg
Platform: TGL SDW chromebook with rt5682-max98373

logger.log
dmesg.log

Activity

  1. added
    bugSomething isn't working
    TGLApplies to Tiger Lake platform
    SDWApplies to SoundWire bus for codec connection
    on Jun 2, 2020
  2. YvonneYang2 commented on Jun 3, 2020

    @YvonneYang2
    Author

    Set them
    amixer -c0 cset name='Left Spk Switch' off
    amixer -c0 cset name='Right Spk Switch' off
    Then check the pm runtime status, still in active status.

  3. added
    P1Blocker bugs or important features
    on Jun 9, 2020
  4. naveen-manohar commented on Jun 11, 2020

    @naveen-manohar

    Observe that master-Controller-1, that connects to max98373 slaves is always active. (Where-as Controller-0 connecting to RT5682 goes to suspend when not in use.)
    cat /sys/bus/soundwire/devices/sdw-master-1/sdw:1:19f:8373:0:3/power/runtime_status
    active
    cat /sys/bus/soundwire/devices/sdw-master-1/sdw:1:19f:8373:0:7/power/runtime_status
    active

  5. RanderWang commented on Jun 11, 2020

    @RanderWang

    The issue is different with I2S mode. And the patch 8947163 doesn't work because user mode API will enable spk pin after card probe on sdw mode.

  6. RanderWang commented on Jun 11, 2020

    @RanderWang
  7. RanderWang commented on Jun 15, 2020

    @RanderWang

    Fixed, I will submit a PR to fix it tomorrow after the last ACK from maximum developer.

  8. YvonneYang2 commented on Jun 16, 2020

    @YvonneYang2
    Author

    Issue is fixed by #2201 and no side effect found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1Blocker bugs or important featuresSDWApplies to SoundWire bus for codec connectionTGLApplies to Tiger Lake platformbugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions