Skip to content

ASoC: Intel: sof-pcm512x: reject the hdac_hdmi driver - #1775

Closed
lyakh wants to merge 1 commit into
thesofproject:topic/sof-devfrom
lyakh:up2-hdmi
Closed

lyakh wants to merge 1 commit into
thesofproject:topic/sof-devfrom
lyakh:up2-hdmi

Conversation

@lyakh

@lyakh lyakh commented Feb 10, 2020

Copy link
Copy Markdown
Collaborator

The sof-pcm512x machine driver can only use the common HDA HDMI driver. This is enabled by using the "use_common_hdmi=yes" snd_sof_intel_hda_common module parameter. If however that parameter isn't specified, ASoC will try to load and probe the snd_soc_hdac_hdmi driver. This will lead to a kernel Oops. The best fix for this would be to force the use of snd_sof_intel_hda_common with this machine driver, but unfortunately this isn't currently possible, because HDMI is initialised before ACPI is probed. Therefore the best available possibility is to simply block the use of the snd_soc_hdac_hdmi driver with this machine.

The sof-pcm512x machine driver can only use the common HDA HDMI
driver. This is enabled by using the "use_common_hdmi=yes"
snd_sof_intel_hda_common module parameter. If however that parameter
isn't specified, ASoC will try to load and probe the
snd_soc_hdac_hdmi driver. This will lead to a kernel Oops. The best
fix for this would be to force the use of snd_sof_intel_hda_common
with this machine driver, but unfortunately this isn't currently
possible, because HDMI is initialised before ACPI is probed.
Therefore the best available possibility is to simply block the use
of the snd_soc_hdac_hdmi driver with this machine.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh

lyakh commented Feb 10, 2020

Copy link
Copy Markdown
Collaborator Author

Note: I'm actually not sure whether we should return 0 or an error code in this case.

@plbossart
plbossart requested a review from kv2019i February 10, 2020 15:09

@kv2019i kv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct as well, but I'd prefer to give an immediate error to the probe with an explanation. This will result in a "silent fail" which is pretty hard for the user to figure out (or figure out from kernelogs logs on github).

@ranj063

ranj063 commented Feb 10, 2020

Copy link
Copy Markdown
Collaborator

This is correct as well, but I'd prefer to give an immediate error to the probe with an explanation. This will result in a "silent fail" which is pretty hard for the user to figure out (or figure out from kernelogs logs on github).

@kv2019i I agree this would be hard to debug. Can we just remove the module param for use_common_hdmi altogether? Why is it even needed now?

@ranj063

ranj063 commented Feb 13, 2020

Copy link
Copy Markdown
Collaborator

@lyakh do we still need this PR after we merge #1777?

@lyakh

lyakh commented Feb 14, 2020

Copy link
Copy Markdown
Collaborator Author

@lyakh do we still need this PR after we merge #1777?

@ranj063 no, don't think so, thanks @kv2019i for fixing this

@lyakh lyakh closed this Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants