Repository navigation
Conversation
The sof-pcm512x machine driver can only use the common HDA HDMI driver. This is enabled by using the "use_common_hdmi=yes" snd_sof_intel_hda_common module parameter. If however that parameter isn't specified, ASoC will try to load and probe the snd_soc_hdac_hdmi driver. This will lead to a kernel Oops. The best fix for this would be to force the use of snd_sof_intel_hda_common with this machine driver, but unfortunately this isn't currently possible, because HDMI is initialised before ACPI is probed. Therefore the best available possibility is to simply block the use of the snd_soc_hdac_hdmi driver with this machine. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Collaborator
Author
|
Note: I'm actually not sure whether we should return 0 or an error code in this case. |
kv2019i
requested changes
Feb 10, 2020
kv2019i
left a comment
Collaborator
There was a problem hiding this comment.
This is correct as well, but I'd prefer to give an immediate error to the probe with an explanation. This will result in a "silent fail" which is pretty hard for the user to figure out (or figure out from kernelogs logs on github).
Collaborator
@kv2019i I agree this would be hard to debug. Can we just remove the module param for use_common_hdmi altogether? Why is it even needed now? |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sof-pcm512x machine driver can only use the common HDA HDMI driver. This is enabled by using the "use_common_hdmi=yes" snd_sof_intel_hda_common module parameter. If however that parameter isn't specified, ASoC will try to load and probe the snd_soc_hdac_hdmi driver. This will lead to a kernel Oops. The best fix for this would be to force the use of snd_sof_intel_hda_common with this machine driver, but unfortunately this isn't currently possible, because HDMI is initialised before ACPI is probed. Therefore the best available possibility is to simply block the use of the snd_soc_hdac_hdmi driver with this machine.