Skip to content

[RFC] ASoC: SOF: topology: make the topology parser IPC agnostic - #3290

Closed
bardliao wants to merge 8 commits into
thesofproject:topic/sof-devfrom
bardliao:wip-topology-ipc-abstraction
Closed

bardliao wants to merge 8 commits into
thesofproject:topic/sof-devfrom
bardliao:wip-topology-ipc-abstraction

Conversation

@bardliao

Copy link
Copy Markdown
Collaborator

This is a succeed PR of #3287. Basically, all commits will be squashed. The first commit is from @ranj063 and I added commit one by one for reviewer to review them easier.

ranj063 and others added 8 commits November 23, 2021 08:32
Make the topology parser IPC agnostic so that when new IPC
versions are introduced, we can reuse the same parser and add
support for the new IPC structures.

This PR is only to showcase how we can achieve this. It doesnt implement
the feature fully but only for the host component.

The basic idea is that when parsing topology, we parse the tuple array
and store them as token/value pairs in the appropriate objects. For
example, in the case of the host component, we store it as part of
struct snd_sof_widget.

Once the tuple arrays are all parsed, we can build the IPC structs
for the respective component whenever needed based on the IPC version
in use. In this PR currently, it is done in the topology complete op.
But it can be moved further out to the pcm_params() for the dynamic
pipeline case when the widgets are actually set up.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
We will have many xxx_token_sizes and will exceed 100 characters

Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
It is general used by both IPC3 and IPC4.

Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
This will be squashed to previous commit.

Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
This will be squashed to previous commit.

Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
This will be squashed to previous commit.

Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
This will be squashed to previous commit.

Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants