Repository navigation
Conversation
Make the topology parser IPC agnostic so that when new IPC versions are introduced, we can reuse the same parser and add support for the new IPC structures. This PR is only to showcase how we can achieve this. It doesnt implement the feature fully but only for the host component. The basic idea is that when parsing topology, we parse the tuple array and store them as token/value pairs in the appropriate objects. For example, in the case of the host component, we store it as part of struct snd_sof_widget. Once the tuple arrays are all parsed, we can build the IPC structs for the respective component whenever needed based on the IPC version in use. In this PR currently, it is done in the topology complete op. But it can be moved further out to the pcm_params() for the dynamic pipeline case when the widgets are actually set up. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
We will have many xxx_token_sizes and will exceed 100 characters Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
It is general used by both IPC3 and IPC4. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
This will be squashed to previous commit. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
This will be squashed to previous commit. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
This will be squashed to previous commit. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
This will be squashed to previous commit. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a succeed PR of #3287. Basically, all commits will be squashed. The first commit is from @ranj063 and I added commit one by one for reviewer to review them easier.