Repository navigation
DAPM graph fixes and clean ups - #675
Conversation
|
This PR should be merged alongside thesofproject/sof#1047 |
d1a3bcc to
4923b6a
Compare
Previously, PCM's were bound to the host component by using an explicit pipeline graph path from the PCM device to the host comp in topology. This graph route is unnecessary and it results in a duplicate connection shown for the host dapm widget from the PCM device. Instead, pcm's should be bound to the respective host comp when the dai is loaded. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
4923b6a to
f94e65e
Compare
|
this PR also fixes #661 Confirmed by Yong to fix the noise issue on the chromebook. @keqiaozhang can you please confirm? |
bardliao
left a comment
There was a problem hiding this comment.
It seems that we should also free capture tables if bind capture pcm failed since the capture table is allocated successfully above.
There was a problem hiding this comment.
what about all the effects/src/asrc that were added at the same time as buffer/scheduler? Should they really be always on?
There was a problem hiding this comment.
these formats may not be used, but at the same time we currently have restrictions on what the topology can do (single format per DAI), and there will be no check that the topology settings are correct and supported by the firmware. We should probably have a layer that does check the topology is indeed supported, otherwise with a single error in a topology file we have a risk of reaching unsupported configurations. it's just too risky.
In short, I would really like the topology to support multiple DAI configs/formats, and a per-platform check in the driver.
There was a problem hiding this comment.
@plbossart makes sense. I can add the check but looking at the formats defined for all platforms, I see no restrictions. All platforms seem to support 16/24/32 bit formats. Is that a mistake? If it is, could you please remind me what they should look like?
e783af7 to
8c79eaa
Compare
|
-#define BDW_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE | \
- SNDRV_PCM_FMTBIT_S32_LE)
-
@plbossart <https://github.com/plbossart> makes sense. I can add the
check but looking at the formats defined for all platforms, I see no
restrictions. All platforms seem to support 16/24/32 bit formats. Is
that a mistake? If it is, could you please remind me what they should
look like?
the main goal is to make sure the SSP are configured in topology with
1..8 channels, frequency between 8..192 and with 16, 24, 32 bits. There
are other exotic formats such as 24_3LE or FLOAT that should not be
handled. More channels as well.
|
@plbossart another question. Is sof_pcm_dai_link_fixup() the place to do the check? Today we seem to align the dai format and channels in the fixup method to fix the min and max rate to fsync rate and the min and max channels to tdm_slots. Do these need to expand to support a range? |
|
@plbossart I've updated the PR with the check for SSP fsync rate and channel count. |
plbossart
left a comment
There was a problem hiding this comment.
Minor issue with the soc-dapm correction, we're missing asrc/encoder/decoder.
There was a problem hiding this comment.
Meh. this isn't the same order as definitions and it's missing asrc/encoder/decoder.
…ays on Currently, buffers, schedulers, src's, encoders, decoders and effect type dapm widgets remain always on as their power_check method is not set. Setting this callback allows these widgets in the audio path to be powered managed properly. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Dai capabilities/configuration are defined in topology. The capabilities defined in the dai drv for the resp platforms don't seem to be used at all. As an additional benefit, removing these cleans up the DAPM graph. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Validate the fsync rate and channel count for SSP before configuring the DAI. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
b370402 to
ca43cb6
Compare
oh yes, fixed now @plbossart |


This PR does the following: