Repository navigation
Conversation
|
please refer to thesofproject/sof#1304 on FW side, they don't need to be merged at the same time as no ABI bump needed. |
plbossart
left a comment
There was a problem hiding this comment.
Why is this necessary? We have other issues to fix really.
And actually it's a really bad idea to have the component types not in a file shared with firmware. It makes the comparisons more complicated...
Agree that it's good if we can share this header file directly with FW, then every time we want to update it, we only need to do it in one place, here making them totally aligned is the prerequisite of sharing it, right? My thought is that we should put struct definitions which we DO need share b/w FW and driver in these headers(e.g. topology.h, abi.h, ipc.h, ...), and sweep all others out of them. |
I don't get what you are suggesting. If there is a change needed in the content of shared files, then we deal with this in a global ABI review. It doesn't matter if the files are only used in one place by the kernel, it's a defined interface and we use it as is. |
Hi Pierre, you are right, I don't want to involve in the long debating about ABI change, what I am doing here is only fix the gap of shared files b/w FW and driver, after this is merged, we will have a same base(the shared files) and bump them to the a same ABI version(e.g. 3.6.0). With this alignment as the prerequisite, we can start our global ABI review process for each ABI update, make sense? |
The enumurated type is used inside sof/topology.c only, split it out from topology.h to make the header file totally aligned with FW. Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
The enumurated type is used inside sof/topology.c only, split it out from topology.h to make the header file totally aligned with FW. Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Bump ABI version to 3.6.0 to align with FW. Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
|
I don't want those enums in topology.c, I mentioned this already. This is not the right way to share information between two repositories. |
The point here is that those enums are not needed in FW side, vice versa, there are some structs/enums used in FW only(transparent to driver), my intention here is weeding them out from shared header files, this will be helpful for ABI version bumping. If we don't want those enums in topology.c, I can add new header file(not shared one) to hold them, opinion? |
|
This: has to be shared. The events don't indeed need to be shared. |
@plbossart actually no, nobody uses this enum inside FW. |
|
@plbossart yes the FW doesnt use the process types. We translate the process type in topology to comp types before sending the IPC to the FW. |
|
well it's broken. We agreed we'd have 'top level' components and then a subtype (today represented as an enum and later with a UUID). I don't want to do surgery on something that's not well defined. There is no rush for this change and it's not useful for now. |
if what you are saying is correct, then the following comment is incorrect in topology.h: struct sof_ipc_comp_process {
struct sof_ipc_comp comp;
struct sof_ipc_comp_config config;
uint32_t size; /**< size of bespoke data section in bytes */
uint32_t type; /**< sof_ipc_process_type */ <<< should be component_type? |
@plbossart Yes, that is correct |
So right there we have a recipe for an incompatible ABI change. We said we would have component types and subtypes, and if we are only passing component types then things will just not scale... |
|
let's revisit this when we rework the 3rd party component support |
The enumurated type is used inside sof/topology.c only, split it out from
topology.h to make the header file totally aligned with FW.
Signed-off-by: Keyon Jie yang.jie@linux.intel.com