You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[FEATURE] Missing codec adapter control for Waves MaxxAudio #7004
which when present in ChromeOS give louder and richer sound compared to when deleted, and the comparison is analogous to that between ChromeOS with those lines and Linux.
To Reproduce amixer -c 0 controls | grep Maxx
Reproduction Rate
all the time
Expected behavior
Being able to see the CODEC_ADAPTER1.0 and 2.0 MaxxChrome controls
Impact
It's rather a slight annoyance as in some situations the speakers aren't loud enough and it's sometimes hard to hear sound
Environment
Branch name and commit hash of the 2 repositories: sof (firmware/topology) and linux (kernel driver).
Kernel: fedora 37 linux stable 6.1.7 21e996306a6afaae88295858de0ffb8955173a15
SOF: sof-bin main 2.2.4 f3fb9dcbca737cdb2cc5c63463e979557f29fd26
Name of the topology file
Topology: sof-tgl-rt1011-rt5682.tplg
Name of the platform(s) on which the bug is observed.
It's not a bug @ignapk, it's just that you can't expect the firmware generated without closed-source libraries to behave the same as the one with closed-source libraries.
sof-bin is based on publicly available code, the firmware used in ChromeOS is different.
Thanks for quick reply and sorry for mistakenly reporting this as a bug. Could this maybe be changed to a Feature Request then? Do you know how I could debug this further, maybe extract necessary closed-source libraries from ChromeOS and somehow use them with Linux?
I've recorded some audio clip in ChromeOS with those cset-tlv commands in HiFi.conf and without them, and the same sound in Linux, and here are screenshots of audacity showing the difference in sound quality:
The left part is without the commands, the right part is with them (both on ChromeOS)
The left part is Linux, the right part is ChromeOS with the commands
There are no plans to include such closed-source libraries in sof-bin, due to obvious code license issues and lack of redistribution rights. You would have the same issue with Chromium I guess.
I can't comment on using closed-source binaries, the only 'open' recommendation I could make if you are trying to work-around loudness issues is to look at the DRC solution provided in the SOF tree (https://github.com/thesofproject/sof/tree/main/src/audio/drc) by @singalsu. That may be an option, though you may also need access to a Tensilica compiler to generate your own firmware.
BTW there are also closed-source firmware versions with speaker protection processing libraries, so you want to be careful with loudness experiments and not damage prematurely your hardware by driving those tiny speakers too hard.
Some comments about open-source audio processing components.
We don't have examples but the IIR EQ and DRC can be used to enhance the speaker. If it's a small speaker, you could just with IIR in the speaker path suppress the low frequencies, e.g. like 4th order high-pass at 200 Hz and give something like 6 - 10 dB boost with the headroom from suppressed bass. With added DRC the boost & limiting could be done better there without clipping.
I've made an EQ tutorial but it has not yet been merged to SOF Docs thesofproject/sof-docs#417 :(. Look at examples in tools/tune/eq. For DRC look at example in tools/tune/drc.
If the topology in the device is such that speaker is using a dedicated DAI that is not shared with headset path, the settings for EQ and DRC can be fixed and embedded to topology. No need to switch between flat and processed in runtime with UCM.
To get the processing to speaker path you need to learn to customize the topologies and replace pass-through or volume pipelines with processing pipelines.
changed the title [-][BUG] Missing codec adapter control for Waves MaxxAudio[/-][+][FEATURE] Missing codec adapter control for Waves MaxxAudio[/+]on Feb 1, 2023
This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.
Activity
plbossart commentedon Jan 30, 2023
It's not a bug @ignapk, it's just that you can't expect the firmware generated without closed-source libraries to behave the same as the one with closed-source libraries.
sof-bin is based on publicly available code, the firmware used in ChromeOS is different.
ignapk commentedon Jan 30, 2023
Thanks for quick reply and sorry for mistakenly reporting this as a bug. Could this maybe be changed to a Feature Request then? Do you know how I could debug this further, maybe extract necessary closed-source libraries from ChromeOS and somehow use them with Linux?
I've recorded some audio clip in ChromeOS with those
cset-tlvcommands in HiFi.conf and without them, and the same sound in Linux, and here are screenshots of audacity showing the difference in sound quality:The left part is without the commands, the right part is with them (both on ChromeOS)

The left part is Linux, the right part is ChromeOS with the commands

plbossart commentedon Jan 30, 2023
There are no plans to include such closed-source libraries in sof-bin, due to obvious code license issues and lack of redistribution rights. You would have the same issue with Chromium I guess.
I can't comment on using closed-source binaries, the only 'open' recommendation I could make if you are trying to work-around loudness issues is to look at the DRC solution provided in the SOF tree (https://github.com/thesofproject/sof/tree/main/src/audio/drc) by @singalsu. That may be an option, though you may also need access to a Tensilica compiler to generate your own firmware.
BTW there are also closed-source firmware versions with speaker protection processing libraries, so you want to be careful with loudness experiments and not damage prematurely your hardware by driving those tiny speakers too hard.
singalsu commentedon Jan 31, 2023
Some comments about open-source audio processing components.
We don't have examples but the IIR EQ and DRC can be used to enhance the speaker. If it's a small speaker, you could just with IIR in the speaker path suppress the low frequencies, e.g. like 4th order high-pass at 200 Hz and give something like 6 - 10 dB boost with the headroom from suppressed bass. With added DRC the boost & limiting could be done better there without clipping.
I've made an EQ tutorial but it has not yet been merged to SOF Docs thesofproject/sof-docs#417 :(. Look at examples in tools/tune/eq. For DRC look at example in tools/tune/drc.
If the topology in the device is such that speaker is using a dedicated DAI that is not shared with headset path, the settings for EQ and DRC can be fixed and embedded to topology. No need to switch between flat and processed in runtime with UCM.
To get the processing to speaker path you need to learn to customize the topologies and replace pass-through or volume pipelines with processing pipelines.
[-][BUG] Missing codec adapter control for Waves MaxxAudio[/-][+][FEATURE] Missing codec adapter control for Waves MaxxAudio[/+]github-actions commentedon Jun 19, 2025
This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.