Repository navigation
Conversation
Add fixed-point Per-Channel AGC Normalization (PCAN) math library under src/math/pcan/ with Octave reference scripts and a Zephyr ztest unit test suite. Extend mel_filterbank_32.c and auditory.h for 32-bit Mel output scaling needed by PCAN. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Unset GTK_PATH in scripts/host-testbench.sh to avoid snap or desktop Octave library conflicts when generating or verifying reference vectors. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Extend the MFCC component with selectable output data types at setup, including 8-bit PCAN normalization and 8-bit soft AGC (AGC8) Mel spectrum output modes used by microWakeWord topologies. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Add NOTIFIER_ID_WOV_DETECT, NOTIFIER_ID_WOV_CTRL, and NOTIFIER_ID_D0IX_STATE notifier IDs along with the D0iX state payload and WOV arbiter notifier/control ABI header. Dispatch NOTIFIER_ID_D0IX_STATE from ipc4_module_process_d0ix() so components such as microWakeWord can switch to low-power D0i3 operation. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
…le rates Support multiple downstream WOV detector pipelines sharing a single KPB history buffer: - Support multi-sink topology binding, dynamic sample rates, and synchronous IPC4 reset. - Fix drain boundary copy, cross-core drain request coherency, and buffer parameter configuration races. - Continue history buffering when a selector sink is full, and disable synchronous draining mode blocking. - Increase KPB_MAX_NO_OF_CLIENTS default to 4 and KPB_MAX_BUFF_TIME to 6000 ms on ACE 3.0+. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com> Co-authored-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Add the WOV arbiter component (CONFIG_COMP_WOV_ARBITER) to arbitrate between multiple concurrent keyword detector slots sharing a single host WoV capture PCM: - First-wins slot arbitration on NOTIFIER_ID_WOV_DETECT, broadcasting NOTIFIER_ID_WOV_CTRL pause/resume to sibling detectors. - Rate-limited PHRASE_DETECTED host notifications (sent once per detection) and active slot reset without requiring pipeline teardown. - Support mixed 16/32-bit sample widths, single active WoV PCM gating, and call-state gate control. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com> Co-authored-by: Naveen Manohar <naveen.m@intel.com> Signed-off-by: Naveen Manohar <naveen.m@intel.com> Co-authored-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Co-authored-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Extend the detect_test sample component to support multi-slot WOV operation alongside wov_arbiter (slot ID configuration, DP thread batching, and WOV_CTRL pause/resume handling). Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com> Co-authored-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
…port Add submanifests/tflm.yml to track tflite-micro, flatbuffers, nnlib-hifi4, gemmlowp, and ruy via west (replacing scripts/tensorflow-clone.sh). Add C++ operator new/delete LLEXT exports, scripts/mww_shim_flatten.py, Xtensa longcalls/text-section-literals, and LLEXT C++ linker discovery. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Add versioned built-in TFLite Micro keyword model headers and matching IPC4 large-config control blobs for banana, hey_jarvis, hi_intel, orange, and strawberry. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Co-authored-by: Liam Girdwood <liam.r.girdwood@linux.intel.com> Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Add the TensorFlow Lite Micro microWakeWord (CONFIG_COMP_MWW) DP keyword spotting module: - Integrates multi-slot MWW with 10 ms DP period, 2 Hz scoring kcontrols, D0i3 low-power listening via NOTIFIER_ID_D0IX_STATE, VAD speech gating, and versioned ABI model blob loading. - Uses static storage for the op resolver/interpreter and optional HiFi4 nnlib acceleration under xt-clang. - Coordinates with wov_arbiter and KPB for multi-slot detection and pre-roll draining. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com> Co-authored-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Co-authored-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Add dataset generation, Piper TTS synthesis, PCAN/MFCC training, model verification, and mtrace feature plotting utilities under src/audio/microwakeword/tune/. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com> Co-authored-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
888f4e5 to
b022552
Compare
lgirdwood
left a comment
There was a problem hiding this comment.
Code Review Summary (MWW / TFLM Commits 4d1f01b217..b022552994)
Focused this review on the 4 MWW/TFLM commits specific to #11511 (4d1f01b217..b022552994), skipping the 7 stacked prerequisite commits from #11504 / #11507 / #11510.
(CI note on stacked base: manifest-check, Zephyr Unit Tests (ZTest), doxygen including strict WARN_AS_ERROR=FAIL_ON_WARNINGS, and kernel-includes all pass here; the failing IPC3 / i.MX / LP64-WIP CI jobs all stem from src/audio/kpb.c:1076 redeclaration of 'sink' under IPC3 and %u vs %zu on LP64 in prerequisite commit 40695efaa8 / #11507.)
Blocking — Build, LLEXT & Global Toolchain Issues
CONFIG_COMP_MWW=mLLEXT build broken (src/audio/microwakeword/llext/CMakeLists.txt:156-158): References three deleted.ccmodel files (../mww_model_data.cc,../mww_model_data_hi_intel.cc,../mww_model_data_orange.cc), breaking CMake configuration wheneverCONFIG_COMP_MWW=morLLEXT_FORCE_ALL_MODULARis enabled.- Unconditional
-mlongcalls/-mtext-section-literalson all Xtensa builds (zephyr/CMakeLists.txt:681-684): Applied underif (CONFIG_XTENSA)even whenCONFIG_COMP_MWW=n, changing call codegen,.textliteral-pool placement, and icache footprint across every Xtensa platform image. src/lib/cpp_new_export.cppportability & runtime safety: Hardcodes 32-bit Itanium mangling (_Znwj/_ZdlPvj, breaking 64-bit LP64_Znwm/_ZdlPvmand missing unsized_ZdlPv), calls raw libcmalloc()(returnsNULLwhenCONFIG_COMMON_LIBC_MALLOC_ARENA_SIZE=0, causing null-deref UB under-fno-exceptions), spins inwhile (1) {}instead ofsof_panic(), and builds underif(CONFIG_CPP)even whenCONFIG_LLEXT=n.
Runtime Bugs, Concurrency & Memory/IPC Safety
- LL-vs-DP race & LL latency in
on_wov_ctrl()(mww.c:265-272): Synchronousnotifier_event()callback setscd->paused = falseand callsMWW_Reset(&cd->mwc)(resource_variables->ResetAll()) from LL/IPC context concurrently with the preemptible DP thread runningMicroInterpreter::Invoke(). - Stack buffer overflow in
mww_log_summary_at_shutdown()(mww.c:406-419): Unclampedlen += snprintk(summary_buf + len, sizeof(summary_buf) - len, ...)underflowssizeof(summary_buf) - lenif 6 operator tags exceed 256 bytes. - Out-of-bounds read/write in
mww_get_config()(mww.c:1068-1096) & missingnum_of_sourcescheck inmww_process()(mww.c:704-715). - Runtime
sof-ctlmodel updates ignored after first prepare (mww.c:612):mww_prepare()checksif (!cd->initialized)withoutcomp_is_new_data_blob_available(cd->model_handler), whilemww_reset()leavescd->initialized = true. mww_model.cchardening: Silent slot aliasing (slot >= kMaxSlots->slot = 0clobbers Slot 0), unverified FlatBuffer offsets (flatbuffers::Verifier), missinginst->input->type == kTfLiteInt8check & leaked placement-newdestructors on error inMWW_InitOps(), and.init_arrayconstructor ong_instances.
Kconfig, Docs & Commit Hygiene
- Dead
CONFIG_COMP_MWW_MODEL_FROM_CONTROL& unguarded Xtensa asm inCONFIG_COMP_MWW_PROFILE(src/audio/microwakeword/Kconfig:34-49). - Local workstation
file:///home/lrg/...URLs, stalemww_instancesnippet, and broken cross-PR doc link insrc/audio/microwakeword/README.md, plussrc/lib/README.mdtier sync and Commit4d1f01b217subject prefix (submanifests, build:->build:orsubmanifests:).
| ${TFLM_PATH}/tensorflow/lite/micro/micro_interpreter.cc | ||
| ../mww_model_data.cc | ||
| ../mww_model_data_hi_intel.cc | ||
| ../mww_model_data_orange.cc | ||
| ../mww_model.cc | ||
| ) |
There was a problem hiding this comment.
Blocking (CONFIG_COMP_MWW=m / LLEXT_FORCE_ALL_MODULAR build failure): mww_model_data*.cc were replaced by mww_model_data_*.h headers #included directly in mww_model.cc (matching src/audio/microwakeword/CMakeLists.txt:175). Leaving these three .cc paths here causes CMake configuration to fail when building MWW as an LLEXT:
| ${TFLM_PATH}/tensorflow/lite/micro/micro_interpreter.cc | |
| ../mww_model_data.cc | |
| ../mww_model_data_hi_intel.cc | |
| ../mww_model_data_orange.cc | |
| ../mww_model.cc | |
| ) | |
| ${TFLM_PATH}/tensorflow/lite/micro/micro_interpreter.cc | |
| ../mww_model.cc | |
| ) |
| if (CONFIG_XTENSA) | ||
| target_compile_options(SOF INTERFACE -mlongcalls) | ||
| zephyr_compile_options(-mtext-section-literals) | ||
| endif() |
There was a problem hiding this comment.
Architecture / global codegen impact: Enabling -mlongcalls and -mtext-section-literals unconditionally under if (CONFIG_XTENSA) alters call sequences (l32r + callx8 vs call8), .text literal placement, and icache footprint across every Xtensa platform build (tgl, mtl, lnl, ptl, wcl, nvl, imx8, imx8m, etc.) even when CONFIG_COMP_MWW=n. Gate this on if (CONFIG_XTENSA AND CONFIG_COMP_MWW) (or a dedicated Kconfig symbol selected only by large C++/TFLM builds):
| if (CONFIG_XTENSA) | |
| target_compile_options(SOF INTERFACE -mlongcalls) | |
| zephyr_compile_options(-mtext-section-literals) | |
| endif() | |
| if (CONFIG_XTENSA AND CONFIG_COMP_MWW) | |
| target_compile_options(SOF INTERFACE -mlongcalls) | |
| zephyr_compile_options(-mtext-section-literals) | |
| endif() |
| [[maybe_unused]] void *sof_operator_new(size_t size) | ||
| { | ||
| return malloc(size); | ||
| } | ||
|
|
||
| [[maybe_unused]] void sof_operator_delete(void *ptr, size_t size) | ||
| { | ||
| (void)size; | ||
| free(ptr); | ||
| } | ||
|
|
||
| /* | ||
| * Same problem as operator new/delete above, one level lower: an abstract | ||
| * class's vtable (e.g. TFLM's MicroOpResolver base) fills the slots for its | ||
| * pure virtual methods with the address of __cxa_pure_virtual, so any | ||
| * translation unit that references such a vtable needs this symbol | ||
| * resolvable even though it should never actually be called at runtime. | ||
| * zephyr/lib/cpp/minimal/cpp_virtual.c already defines a real | ||
| * __cxa_pure_virtual, but -- exactly like cpp_new.cpp above -- nothing in | ||
| * the base image build references it directly, so it is never pulled into | ||
| * the link or exported for LLEXT modules to resolve against. Provide our | ||
| * own and export it under the same name. | ||
| */ | ||
| [[maybe_unused]] void sof_cxa_pure_virtual(void) | ||
| { | ||
| while (1) { | ||
| } | ||
| } | ||
|
|
||
| } /* namespace */ | ||
|
|
||
| extern "C" [[maybe_unused]] void __assert_no_args(void) | ||
| { | ||
| while (1) { | ||
| } | ||
| } | ||
|
|
||
| EXPORT_SYMBOL_NAMED(sof_operator_new, _Znwj); | ||
| EXPORT_SYMBOL_NAMED(sof_operator_delete, _ZdlPvj); | ||
| EXPORT_SYMBOL_NAMED(sof_cxa_pure_virtual, __cxa_pure_virtual); | ||
| EXPORT_SYMBOL(__assert_no_args); |
There was a problem hiding this comment.
Portability & runtime safety issues:
- LP64 /
size_tmangling mismatch:_Znwj/_ZdlPvjhardcode 32-bitunsigned intsize_t. On 64-bit targets (imx93_a55, 64-bitnative_sim) or toolchains wheresize_tisunsigned long, C++ manglesoperator new(size_t)/operator delete(void*, size_t)to_Znwm/_ZdlPvm— and unsizedoperator delete(void*)(_ZdlPv) is not exported. malloc()under Zephyr minimal libc +-fno-exceptions: WhenCONFIG_COMMON_LIBC_MALLOC_ARENA_SIZE=0,malloc()returnsNULL(or fails to link), and under-fno-exceptionsreturningnullptrfrom non-nothrowoperator newcauses immediate null-deref UB in C++ constructors. Route through SOF's heap (rballoc/sof_heap_alloc) — orsof_panic(SOF_IPC_PANIC_MEM)if this is strictly an unreachable linker stub — and callsof_panic(SOF_IPC_PANIC_EXCEPTION)/k_oops()instead ofwhile (1) {}insof_cxa_pure_virtual()and__assert_no_args().- Build gating & doc sync: Gate
add_local_sources(sof cpp_new_export.cpp)insrc/lib/CMakeLists.txt:13onif(CONFIG_CPP AND CONFIG_LLEXT)and mentioncpp_new_export.cppinsrc/lib/README.md.
| } else if (n->cmd == WOV_ARB_CMD_RESUME) { | ||
| comp_info(dev, "mww slot %u: resumed by arbiter", cd->wov_slot_id); | ||
| cd->paused = false; | ||
| cd->vad_active_hops = 0; | ||
| memset(cd->prob_hist, 0, sizeof(cd->prob_hist)); | ||
| MWW_Reset(&cd->mwc); | ||
| } | ||
| } |
There was a problem hiding this comment.
Concurrency bug & LL-context hazard: on_wov_ctrl() is invoked synchronously via notifier_event() from wov_arbiter (which runs in LL 1 ms context or IPC context), whereas mww_process() runs in its own preemptible DP thread:
- Clearing
cd->paused = falsebeforeMWW_Reset(&cd->mwc)— and callingMWW_Reset()(resource_variables->ResetAll()) directly fromon_wov_ctrl()— races with an in-flightMicroInterpreter::Invoke()in the DP thread and zeroes tensor-arena ring buffers inside the 1 ms LL tick. - Instead, set an atomic
pending_resetflag here (before clearingpaused) and executeMWW_Reset()+prob_hist/vad_active_hopsreset at the top ofmww_process()on the DP thread.
| for (i = 0; (k = MWW_ProfileGet(&cd->mwc, i, &tag, &avg)) > 0; i++) { | ||
| n = k; | ||
| total += avg; | ||
| if (!len) | ||
| len = snprintk(summary_buf, sizeof(summary_buf), | ||
| "[MWW PROFILE Slot %u]", cd->wov_slot_id); | ||
| len += snprintk(summary_buf + len, sizeof(summary_buf) - len, | ||
| " %d:%s=%u", i, tag, avg); | ||
| if ((i % 6) == 5) { | ||
| if (dev) | ||
| comp_info(dev, "%s", summary_buf); | ||
| len = 0; | ||
| } | ||
| } |
There was a problem hiding this comment.
Stack buffer overflow (CONFIG_COMP_MWW_PROFILE=y): snprintk() returns the number of characters that would have been formatted (not clamped to the remaining buffer size). If 6 operator names/counts exceed sizeof(summary_buf) (256), len becomes >= sizeof(summary_buf) and sizeof(summary_buf) - len underflows size_t to a huge value on the next iteration, writing past the end of summary_buf. Clamp or flush before len reaches sizeof(summary_buf).
| mww_instance() : | ||
| slot_id(0), arena(nullptr), arena_size(kArenaSize), | ||
| model(nullptr), input(nullptr), output(nullptr), | ||
| interpreter(nullptr), allocator(nullptr), | ||
| resource_variables(nullptr), op_resolver(nullptr) | ||
| { | ||
| } | ||
| }; | ||
|
|
||
| static struct mww_instance g_instances[kMaxSlots]; | ||
|
|
There was a problem hiding this comment.
LLEXT / C++ static init: A user-provided non-constexpr constructor on static struct mww_instance g_instances[kMaxSlots] forces a .init_array runtime initializer (_GLOBAL__sub_I_mww_model.cc). Using inline default member initializers (uint8_t slot_id = 0; ... size_t arena_size = kArenaSize;) with constexpr mww_instance() = default; keeps g_instances constant-initialized in .data/.bss with zero .init_array dependency.
| uint8_t slot = mwc->slot_id; | ||
| if (slot >= kMaxSlots) | ||
| slot = 0; | ||
|
|
||
| struct mww_instance *inst = &g_instances[slot]; | ||
| inst->slot_id = slot; | ||
| mwc->instance = inst; | ||
|
|
||
| if (!model_tflite || model_size == 0) { | ||
| mwc->error = "no model provided"; | ||
| return -EINVAL; | ||
| } | ||
|
|
||
| inst->model = tflite::GetModel(model_tflite); | ||
| if (inst->model->version() != TFLITE_SCHEMA_VERSION) { | ||
| mwc->error = "failed to load model (schema mismatch)"; | ||
| return -EINVAL; | ||
| } | ||
|
|
There was a problem hiding this comment.
Slot collision & FlatBuffer verification:
if (slot >= kMaxSlots) slot = 0;silently aliases out-of-range slots ontog_instances[0]/g_arenas[0], clobbering an active Slot 0 interpreter. Return-EINVALwhenslot >= kMaxSlots, and guard against two live module instances claiming the sameslot.model_sizeis unused after the== 0check, andmww_parse_model()accepts bare"TFL3"blobs without a header/CRC (mww.c:545). Runflatbuffers::Verifier verifier(model_tflite, model_size); if (!tflite::VerifyModelBuffer(verifier)) return -EINVAL;beforetflite::GetModel()so malformed control blobs cannot read out of bounds.
| inst->input = inst->interpreter->input(0); | ||
| if (!inst->input) { | ||
| mwc->error = "input interpreter NULL"; | ||
| return -EINVAL; | ||
| } | ||
|
|
||
| int in_elems = 1; | ||
| for (int i = 0; i < inst->input->dims->size; i++) | ||
| in_elems *= inst->input->dims->data[i]; | ||
| if (kFeatureElementCount != in_elems) { | ||
| mwc->error = "input interpreter shape incompatible"; | ||
| return -EINVAL; | ||
| } | ||
|
|
||
| inst->output = inst->interpreter->output(0); | ||
| if (!inst->output) { | ||
| mwc->error = "output interpreter NULL"; | ||
| return -EINVAL; | ||
| } | ||
|
|
||
| if (inst->output->type != kTfLiteInt8 && inst->output->type != kTfLiteUInt8) { | ||
| mwc->error = "output tensor type != int8/uint8"; | ||
| return -EINVAL; | ||
| } | ||
|
|
||
| /* LOGISTIC output scale is fixed to 1/256, so raw - zero_point is Q0.8 */ | ||
| if (inst->output->params.zero_point != (inst->output->type == kTfLiteInt8 ? -128 : 0)) { | ||
| mwc->error = "output tensor is not a logistic probability"; | ||
| return -EINVAL; | ||
| } | ||
|
|
There was a problem hiding this comment.
Missing input type check & leaked placement-new destructors on error:
MWW_InitOps()validatesinst->output->type(kTfLiteInt8/kTfLiteUInt8) but never checksinst->input->type == kTfLiteInt8(orinst->input->bytes == kFeatureElementCount), whereasMWW_ProcessClassify()unconditionally writes viatflite::GetTensorData<int8_t>(inst->input). Also guardin_elems *= inst->input->dims->data[i]against negative/overflowingdims.- On all error returns in lines
313–339,inst->interpreter->~MicroInterpreter()andinst->op_resolver->~MwwOpResolver()are not called andinst->interpreter/inst->op_resolverremain non-null.
| config COMP_MWW_PROFILE | ||
| bool "Per-operator inference cycle profiling" | ||
| default n | ||
| help | ||
| Measure CCOUNT cycles spent in each TFLM operator of the MWW | ||
| model and log the per-inference averages in the stream shutdown | ||
| summary. Only effective for the static (non-LLEXT) build. | ||
|
|
||
| config COMP_MWW_MODEL_FROM_CONTROL | ||
| bool "Load MWW model from bytes control instead of built-in header" | ||
| default n | ||
| help | ||
| When enabled, the MWW wake-word model is loaded from a runtime | ||
| or topology configuration data blob via binary kcontrol (bytes control) | ||
| instead of using the static mww_model_data embedded in the firmware image. | ||
|
|
There was a problem hiding this comment.
Two Kconfig issues:
COMP_MWW_PROFILE(line 34) has nodepends on XTENSA, whilemww_ccount()(mww_model.cc:55) executes raw Xtensarsr.ccountinline assembly — either adddepends on XTENSAhere or use portablek_cycle_get_32()inmww_model.cc.COMP_MWW_MODEL_FROM_CONTROL(line 42) is never referenced anywhere in C/C++ or CMake, so enabling it still compiles all built-inmww_model_data_*.harrays (~150 KB) into the image instead of omitting them.
| | Target Platform | Manifest File | Output Topology Binary | DMIC Driver Version | | ||
| |---|---|---|---| | ||
| | **Panther Lake (PTL / ACE 3.0)** | [`dmic-wov-multi-ptl-4ch-manifest.conf`](file:///home/lrg/work/sof-tgl/sof-wov/tools/topology/topology2/dmic-wov-multi-ptl-4ch-manifest.conf) | `sof-ptl-dmic-wov-multi-4ch.tplg` | 5 | | ||
| | **Tiger Lake (TGL / CAVS 2.5)** | [`dmic-wov-multi-4ch-manifest.conf`](file:///home/lrg/work/sof-tgl/sof-wov/tools/topology/topology2/dmic-wov-multi-4ch-manifest.conf) | `sof-tgl-dmic-wov-multi-4ch.tplg` | 1 | | ||
| | **Wildcat Lake (WCL / ACE 3.0)** | symlink to the PTL topology | `sof-wcl-dmic-wov-multi-4ch.tplg` | 5 | | ||
|
|
||
| --- | ||
|
|
||
| ## Multi-Instance Design & Memory Management | ||
|
|
||
| ### 1. Single Codebase, Three Isolated Instances | ||
| Previous implementations relied on global static variables, limiting execution to one model. The updated `mww_model.cc` introduces explicit instance tracking: | ||
|
|
||
| ```cpp | ||
| constexpr int kMaxSlots = 3; | ||
|
|
||
| struct mww_instance { | ||
| const tflite::Model* model = nullptr; | ||
| tflite::MicroInterpreter* interpreter = nullptr; | ||
| TfLiteTensor* input = nullptr; | ||
| TfLiteTensor* output = nullptr; | ||
| float input_scale = 0.0f; | ||
| int32_t input_zero_point = 0; | ||
| bool initialized = false; | ||
| }; | ||
|
|
||
| static struct mww_instance g_instances[kMaxSlots]; | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Doc cleanup:
- Lines
115–116contain hardcoded workstationfile:///home/lrg/work/sof-tgl/sof-wov/...links — replace with relative repo paths (or plain code spans until#11508lands). - Lines
129–138show an outdatedstruct mww_instancedefinition (input_scale,input_zero_point,initialized) that no longer matchesmww_model.cc:129-148. - Line
204below links to../../../doc/developer_guides/wov_ecns_integration_guide.md, which is in#11509rather than this PR.
Split from #11471 (
wov-d0i3).Summary
submanifests/tflm.yml) and C++/LLEXT toolchain support (src/lib/cpp_new_export.cpp,scripts/mww_shim_flatten.py).banana,hey_jarvis,hi_intel,orange,strawberry) and IPC4tools/ctl/ipc4/mww/control blobs.src/audio/microwakeword/,CONFIG_COMP_MWW).mtracetuning scripts undersrc/audio/microwakeword/tune/.Testing
intel_adsp/ace30/ptl) withCONFIG_SOF_STAGING=y,CONFIG_CPP=y,CONFIG_STD_CPP17=y,CONFIG_COMP_MWW=y,CONFIG_COMP_MFCC=y,CONFIG_COMP_WOV_ARBITER=y, andCONFIG_MATH_PCAN=y, and verifiedscripts/check_kernel_includes.py --strict.