Skip to content

include: split uapi headers into more directories - #1504

Merged
lgirdwood merged 1 commit into
thesofproject:masterfrom
jajanusz:headers-restructure
May 31, 2019
Merged

lgirdwood merged 1 commit into
thesofproject:masterfrom
jajanusz:headers-restructure

Conversation

@jajanusz

Copy link
Copy Markdown
Contributor

As discussed in: #1471

Some of interface headers are not needed by kernel,
but are needed by user-space applications, so we can split them
into multiple directories that indicate their purpose.

Signed-off-by: Janusz Jankowski janusz.jankowski@linux.intel.com

@jajanusz

Copy link
Copy Markdown
Contributor Author

@plbossart I made kernel folder to reflect what's there: https://github.com/thesofproject/linux/tree/topic/sof-dev/include/uapi/sound/sof

I guess that all headers (excluding ipc) that kernel needs.

@jajanusz
jajanusz force-pushed the headers-restructure branch from 73d82fc to 06778e2 Compare May 31, 2019 13:40

@plbossart plbossart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Comment thread CODEOWNERS Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: what does the "**" do here? Is this better or different than a single "*"?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* matches only one level of files. If you want to match whole subdir tree you have to use **

@lgirdwood lgirdwood left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jajanusz thanks, this leaves me clear to do #1403 now. These were last two blockers for v1.3.
@wenqingfu fyi.

@lgirdwood

Copy link
Copy Markdown
Member

@zrombel will CI be available for this today or is it offline now until Monday ?

@tlauda

tlauda commented May 31, 2019

Copy link
Copy Markdown
Contributor

@jajanusz There are some conflicts.

Some of interface headers are not needed by kernel,
but are needed by user-space applications, so we can split them
into multiple directories that indicate their purpose.

Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
@jajanusz
jajanusz force-pushed the headers-restructure branch from 06778e2 to 38ff262 Compare May 31, 2019 16:29
@jajanusz

Copy link
Copy Markdown
Contributor Author

@jajanusz There are some conflicts.

Fixed

@lgirdwood
lgirdwood merged commit e39ed5e into thesofproject:master May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants