Skip to content

installer: add adl and adl-s links - #4804

Merged
lgirdwood merged 2 commits into
thesofproject:mainfrom
marc-hb:installer-adl
Sep 29, 2021
Merged

lgirdwood merged 2 commits into
thesofproject:mainfrom
marc-hb:installer-adl

Conversation

@marc-hb

@marc-hb marc-hb commented Sep 27, 2021 •

Copy link
Copy Markdown
Collaborator

See (latest) commit messages

@thesofproject thesofproject deleted a comment from keyonjie Sep 27, 2021
@thesofproject thesofproject deleted a comment from keyonjie Sep 27, 2021
@marc-hb
marc-hb force-pushed the installer-adl branch 2 times, most recently from a6666a2 to 68f0528 Compare September 27, 2021 06:47
@marc-hb

marc-hb commented Sep 27, 2021 •

Copy link
Copy Markdown
Collaborator Author

EDIT: both issues below fixed now.

The Zephyr build failure is due to the recent SDK requirement bump (0.13.1), unrelated work in progress, see #4805

Checkpatch is lost in the weeds.

@marc-hb

marc-hb commented Sep 27, 2021

Copy link
Copy Markdown
Collaborator Author

The /lib/firmware-like output modified by this PR is the input to https://github.com/thesofproject/sof-bin/blob/main/HOWTO-new-release.md#release

@kv2019i kv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marc-hb . Patch content looks, but I'd reword the second commit message to be a bit more formal. The HW details have been described earlier in commit "config: intel: use PCH name for tigerlake"

Comment thread installer/GNUmakefile Resolved
Avoids semi-random order like:

-- tests/staging_sof_ref.txt
++ sof/installer-builds/staging_sof_tree.txt
@ -1,7 +1,7 @@
 .
 ├── community
-│   ├── sof-adl.ri -> sof-tgl.ri
 │   ├── sof-adl-s.ri -> sof-tgl-h.ri
+│   ├── sof-adl.ri -> sof-tgl.ri
 │   ├── sof-apl.ri
 │   ├── sof-cfl.ri -> sof-cnl.ri
 │   ├── sof-cml.ri -> sof-cnl.ri
@ -16,10 +16,10 @@

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
ADL and ADL-S binaries share FW build configuration with TGL and TGL-H.

See also issue thesofproject#3491 and commit 15e03fd ("config: intel: use PCH
name for tigerlake") and the corresponding review in PR thesofproject#3451.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>

@kv2019i kv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @marc-hb !

@lgirdwood

Copy link
Copy Markdown
Member

This PR introduces installer updates and has no impact on CI runtime tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants