Repository navigation
.github/zephyr: unset stale ZEPHYR_SDK_INSTALL_DIR and point at the latest zephyr container again - #4811
Merged
Conversation
…chains Currently set to obsolete 0.12.4. Better remove it here for everyone rather than overriding it in Github Actions only. Also symlinks the toolchains in /opt to /home to fix autodetection Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Tired of fixing Zephyr breakages all the time (latest in zephyrproject-rtos/zephyr#38733) Also unhardcode ZEPHYR_SDK_INSTALL_DIR thanks to the previous commit. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
force-pushed
the
zephyr-sdk-0131
branch
from
September 28, 2021 02:34
a8a4839 to
1dce542
Compare
marc-hb
marked this pull request as ready for review
September 28, 2021 02:52
marc-hb
requested review from
cujomalainey,
dbaluta,
lgirdwood and
zrombel
as code owners
September 28, 2021 02:52
marc-hb
requested review from
aiChaoSONG,
dcpleung,
iuliana-prodan,
keqiaozhang,
lyakh and
nashif
September 28, 2021 02:53
aiChaoSONG
approved these changes
Sep 28, 2021
aiChaoSONG
left a comment
Collaborator
There was a problem hiding this comment.
I have no objection to use the latest zephyr docker image
marc-hb
referenced
this pull request
in zephyrproject-rtos/docker-image
Sep 28, 2021
Install the SDK 0.13.1 release for CI. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
Collaborator
Author
|
After some git archeology I found zephyrproject-rtos/docker-image#59 that added in May a new |
lgirdwood
approved these changes
Sep 28, 2021
marc-hb
commented
Sep 28, 2021
| sudo apt-get -y install tree | ||
|
|
||
| # Unset stale ZEPHYR_SDK_INSTALL_DIR variable pointing to obsolete | ||
| # 0.12.4 as of container 0.18.x |
Collaborator
Author
There was a problem hiding this comment.
Inaccurate comment fixed in followup #4819
Collaborator
Author
|
zephyrproject-rtos/docker-image#77 removes ZEPHYR_SDK_INSTALL_DIR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit messages