Repository navigation
Conversation
Contributor
Author
|
Oh, but I forgot to enable chain dma from the topology. |
Resurect the old ipc4_create_pipeline() as ipc4_create_pipeline_old() for ipc4_create_chain_dma(). This is used by the old chain dma implementation. Signed-off-by: Jyri Sarha <jyri.sarha@intel.com>
This reverts commit 19df10f. This revert restores the old version if chained dma implementation, which is currently the only version that has ever passed multiple-pause-resume test. Signed-off-by: Jyri Sarha <jyri.sarha@intel.com>
The known issues with the pipeline-free chain DMA implementation has now been solved, so we can re-enable chain DMA usage. This reverts commit c3807ae. Signed-off-by: Jyri Sarha <jyri.sarha@intel.com>
jsarha
force-pushed
the
restore_old_chain_dma_implementation
branch
from
February 16, 2023 08:51
ec3ccce to
bd70ba5
Compare
Collaborator
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just curious if the old version would still pass the whole CI. May also be useful in comparing the logic to find out what goes wrong with the new implementation. But I have no intention of proposing to merge this.