Repository navigation
fix(core): check idempotency key catalog in isIdempotencyKey - #5138
theeaashish wants to merge 1 commit into
Conversation
|
|
Hi @theeaashish, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details. |
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Closes #5130
✅ Checklist
Testing
packages/core/src/v3/idempotencyKeys.test.tsverifying that a raw 64-character string is hashed with the parent run ID (run-scoped) rather than treated as an already-hashed global key, while keys created viaidempotencyKeys.create()preserve theirglobalorrunscope.pnpm --filter @trigger.dev/core exec vitest run src/v3/idempotencyKeys.test.ts(all 21 tests passing) along withformat,lint, andknip.Changelog
Updated
isIdempotencyKey()in@trigger.dev/coreto verifygetIdempotencyKeyOptions(value) !== undefinedinstead of relying solely onvalue.length === 64, preventing raw 64-character strings from bypassing parent-run scoping inmakeIdempotencyKey().Screenshots
N/A (core SDK logic and unit tests only).
💯