Repository navigation
Conversation
- Replace the external `diff` crate dependency with the `ses` crate across all diff modules - Update pattern matching in context, ed, normal, side, and unified diff implementations to use `ses::Change` variants (`Delete`, `Insert`, `Equal`)
shadowmkj
marked this pull request as ready for review
November 19, 2026 14:52
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
===========================
===========================
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
sorry but it is unlikely that we will take add this dependency over similar |
Contributor
Author
|
That's what I want to know, since This crate is just temporary and for isolating the core algorithm from this repository (so I can research and play around), and it's small enough to be merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to evaluate
ses(Shortest Edit Script) for sequence comparison using Eugene Myers' diff algorithm, and to compare CodSpeedperformance and hunk compatibility against
mainand #415 (similar).sesis the minimal crate implementation of Myers' diff algorithm. https://github.com/shadowmkj/sesUnlike
similar,sesproduces hunks that are 1:1 compatible with GNU diff's alignments and tie-breaking .What changed:
diffcrate dependency withsesacrossnormal_diff,unified_diff,context_diff,ed_diff, andside_diff.tests/by-util/test_diff.rsverifying 1:1 GNU diff compatibility(symmetrical/asymmetrical ties, replacements, and boundary changes).