Skip to content

fix(app): match the demo traces rollup's dimension columns to its table - #3736

Draft
alex-fedotyev wants to merge 1 commit into
mainfrom
alex/HDX-6120-trace-rollup-1-demo-mv-config
Draft

alex-fedotyev wants to merge 1 commit into
mainfrom
alex/HDX-6120-trace-rollup-1-demo-mv-config

Conversation

@alex-fedotyev

@alex-fedotyev alex-fedotyev commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Stack

Layer 1 of 5 in a GitHub stack (stack #3741). GitHub shows each layer's base as the branch below it, but the stack's base is main: merging any PR lands it and every PR below it on main, one squashed commit each. Each PR's diff is only its own layer, and CI runs as if each targets main:

  1. fix(app): match the demo traces rollup's dimension columns to its table #3736 Demo traces rollup lists its real dimension columns (this PR)
  2. fix(common-utils): merge DDSketch and GK quantile states with their accuracy #3737 DDSketch and GK states merge with their accuracy
  3. fix(app): keep search counts exact when a materialized view serves the chart #3738 Search counts stay exact when a view serves them
  4. feat(app): show materialized view acceleration on the trace search RED charts #3739 Acceleration indicator on the trace search RED charts
  5. feat(app): infer a materialized view's minimum date from when it was created #3740 Minimum date inferred from the view's creation time

The layers are independent fixes to how charts read materialized views, ordered so the smallest land first. They prepare for a default trace rollup, which comes in a follow-up stack.

Summary

The demo connection registers two rollups for Demo Traces. Its config for otel_traces_1m_v2 lists ServiceName, SpanName, SpanKind as the dimensions, but the table is grouped by ServiceName, StatusCode, SpanName (checked with SHOW CREATE TABLE otel.otel_traces_1m_v2 on the demo service). Chart queries weren't affected, since every rewrite is checked with EXPLAIN first. But filter value lookups tried the view for SpanKind and fell back after a failed EXPLAIN, and the view's details in the acceleration dialog listed a column the table doesn't have.

This lists the table's real columns.

Test plan

  • Compared the config against the table definition on the demo service.
  • tsc and lint for the app.

Part of HDX-6120.

The demo connection describes otel_traces_1m_v2 as grouped by ServiceName,
SpanName and SpanKind, but the table is grouped by ServiceName, StatusCode and
SpanName. Filter value lookups tried the view for SpanKind and failed the
EXPLAIN check, and the view's details showed a column it doesn't have.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Nov 20, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f7882c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hyperdx-oss Ready Ready Preview Nov 20, 2026 6:21am UTC
hyperdx-storybook Ready Ready Preview Nov 20, 2026 6:21am UTC

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

Duplicate code analysis

No new duplicate code introduced by this PR.


jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 108 in total (1.13%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

@github-actions

Copy link
Copy Markdown
Contributor

E2E Test Results

✅ All tests passed • 472 passed • 1 skipped • 1092s

Status Count
✅ Passed 472
❌ Failed 0
⚠️ Flaky 10
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

This branch was successfully deployed

2 active deployments
Preview – hyperdx-oss — f7882c84 Deployed Nov 20, 2026 by vercel[bot]
Preview – hyperdx-storybook — f7882c84 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant