Repository navigation
fix(app): match the demo traces rollup's dimension columns to its table - #3736
Draft
alex-fedotyev wants to merge 1 commit into
Draft
alex-fedotyev wants to merge 1 commit into
alex-fedotyev wants to merge 1 commit into
Conversation
The demo connection describes otel_traces_1m_v2 as grouped by ServiceName, SpanName and SpanKind, but the table is grouped by ServiceName, StatusCode and SpanName. Filter value lookups tried the view for SpanKind and failed the EXPLAIN check, and the view's details showed a column it doesn't have. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: f7882c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
Contributor
E2E Test Results✅ All tests passed • 472 passed • 1 skipped • 1092s
Tests ran across 4 shards in parallel. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Layer 1 of 5 in a GitHub stack (stack #3741). GitHub shows each layer's base as the branch below it, but the stack's base is
main: merging any PR lands it and every PR below it onmain, one squashed commit each. Each PR's diff is only its own layer, and CI runs as if each targetsmain:The layers are independent fixes to how charts read materialized views, ordered so the smallest land first. They prepare for a default trace rollup, which comes in a follow-up stack.
Summary
The demo connection registers two rollups for Demo Traces. Its config for
otel_traces_1m_v2listsServiceName, SpanName, SpanKindas the dimensions, but the table is grouped byServiceName, StatusCode, SpanName(checked withSHOW CREATE TABLE otel.otel_traces_1m_v2on the demo service). Chart queries weren't affected, since every rewrite is checked withEXPLAINfirst. But filter value lookups tried the view forSpanKindand fell back after a failedEXPLAIN, and the view's details in the acceleration dialog listed a column the table doesn't have.This lists the table's real columns.
Test plan
tscand lint for the app.Part of HDX-6120.