Repository navigation
feat(app): show materialized view acceleration on the trace search RED charts - #3739
Draft
alex-fedotyev wants to merge 1 commit into
Draft
alex-fedotyev wants to merge 1 commit into
alex-fedotyev wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: b24f1a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
This was referenced Nov 20, 2026
Contributor
E2E Test Results✅ All tests passed • 472 passed • 1 skipped • 1047s
Tests ran across 4 shards in parallel. |
…D charts The Throughput, Errors and Duration tiles already read from a source's materialized views when one fits, but they hid the indicator dashboard tiles show, so there was no way to tell whether a tile was accelerated or why not. The tiles now show it; the date-range indicator stays off because the search range is exact. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alex-fedotyev
force-pushed
the
alex/HDX-6120-trace-rollup-4-mv-indicator
branch
from
November 20, 2026 06:27
e1fac0a to
b24f1a0
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Layer 4 of 5 in a GitHub stack (stack #3741). GitHub shows each layer's base as the branch below it, but the stack's base is
main: merging any PR lands it and every PR below it onmain, one squashed commit each. Each PR's diff is only its own layer, and CI runs as if each targetsmain:The layers are independent fixes to how charts read materialized views, ordered so the smallest land first. They prepare for a default trace rollup, which comes in a follow-up stack.
Summary
The Throughput, Errors and Duration tiles on trace search already read from a source's materialized views when one fits, but they hid the acceleration indicator that dashboard tiles show, so there was no way to tell whether a tile was accelerated or why not. They now show it, with the same dialog that lists which view served the chart or why each view couldn't.
The date-range indicator stays off, because the search range stays exact when a view serves the chart (see the PR below this one). The search histogram keeps its current look: it has no title row, so the indicator there would add a header to every search, including sources without views.
Screenshots
Last hour on the demo traces, where a 1-minute view serves all three tiles. Light theme:
Dark theme:
The dialog from the Duration tile, naming the view that served it and why the other one couldn't:
The default 15-minute range uses 15-second buckets, finer than the views, so the tiles read the source table and say so:
Test plan
materialized-views.spec.ts): on theE2E Traces MVfixture source over the last hour, all three tiles show Accelerated, and the dialog lists the view.count()over the same range exactly (3,077,342 and 3,078,092 for two one-hour windows, 762,061 for 15 minutes).Part of HDX-6120.