Repository navigation
Remove imports from black_scholes - #165
Hardcode84 wants to merge 25 commits into
Conversation
cf62d55 to
a5bb14b
Compare
|
@diptorupd I think it is ready for review. If this approach is ok, I'll update rest of the workloads in followup PRs. But, before this, can you please fix the CI so it can actually report errors. Thanks |
|
The changes failed the single black scholes run: For example: Please take a look. |
This should be fixed now. Added |
|
It seems fixed the most of the issue. The hanging seems going away. One thing is showing up after fix is somehow sycl test is disabled, as seen here: |
|
It seems the logic of running dpbench tests is broken. All the cases didn't launch correctly after black scholes. Here is an example for error message: |
|
BTW, I'm seeing |
|
sycl impl just refuses to cooperate, will look into it more tomorrow |
|
Seems to work now, but
|
8b91c27 to
e7dd2f0
Compare
e7dd2f0 to
23c9f40
Compare
|
Can we get this merged? |
23c9f40 to
6f283e8
Compare
|
@diptorupd @mingjie-intel can we merge this? |
|
Some comments here:
|
Lets make similar changes to all benchmarks in this PR so that we have all the changes before merge this. |
New PRs please. I will like to get this PR merged as-is if possible. |
I agree. |
| results_dict = manager.dict() | ||
| p = Process( | ||
| target=tout.exit_after(timeout)(_exec), | ||
| target=_exec, |
There was a problem hiding this comment.
Please revert this and update in #166 if needed
There was a problem hiding this comment.
Without it it fails on my win machine in 100% cases so I can't test it.
| ) | ||
| p.start() | ||
| res = p.join(timeout * 1.2) | ||
| res = p.join(timeout) |
| {outarr: npzfile[outarr]} | ||
| ) | ||
| os.remove(output_npz) | ||
| try: |
There was a problem hiding this comment.
Without it it fails on my win machine in 100% cases so I can't test it.
__init__.py, import them dynamically usingimportlib.import_modulem donenumpyandpythonimpls are still needed to be imported explicitly as reference implementation checking code wasn't adapted to new impltarget=tout.exit_after(timeout)(_exec),was failing on my py 3.9 win machine withAttributeError: Can't pickle local object 'exit_after.<locals>.outer.<locals>.inner', need to investigateos.remove(output_npz)was failing withThe process cannot access the file because it is being used by another process