Skip to content

Remove imports from all benchmarks - #179

Merged
diptorupd merged 1 commit into
mainfrom
nuke-imports
Mar 28, 2023
Merged

diptorupd merged 1 commit into
mainfrom
nuke-imports

Conversation

@ZzEeKkAa

@ZzEeKkAa ZzEeKkAa commented Mar 23, 2023 •

Copy link
Copy Markdown
Contributor

Original PR: #165

This PR introduces updates to infrastructure that allow it to pick up all the implementation automatically and avoid adding boilerplate code. However there is an option to put config into benchmark config (instead of configuring it at __init__.py like it was introduced in original PR). The syntax left the same. In contrast to the original PR, this one does pick up all the functions dynamically during initialization of the Benchmark, not during execution. It lead to more elegant code and less places to update as well as avoid reinitialization during runtime.

Summary of current implementation
=================================
                 As_of          benchmark problem_size      numba_dpex_k   numba_dpex_p      numba_dpex_n              dpnp          numpy         python        numba_n       numba_np      numba_npr          dpcpp
0  03.28.2023_10.17.40      black_scholes            S           Success        Success           Success           Success        Success        Success        Success        Success        Success        Success
1  03.28.2023_10.17.40             dbscan            S  Failed Execution        Success     Unimplemented     Unimplemented  Unimplemented        Success        Success  Unimplemented        Success  Unimplemented
2  03.28.2023_10.17.40             gpairs            S           Success        Success     Unimplemented  Failed Execution        Success  Unimplemented        Success  Unimplemented        Success        Success
3  03.28.2023_10.17.40             kmeans            S           Success        Success           Success     Unimplemented        Success        Success        Success  Unimplemented        Success  Unimplemented
4  03.28.2023_10.17.40                knn            S           Success        Success     Unimplemented     Unimplemented  Unimplemented        Success  Unimplemented  Unimplemented        Success        Success
5  03.28.2023_10.17.40            l2_norm            S           Success  Unimplemented  Failed Execution           Success        Success  Unimplemented        Success        Success  Unimplemented        Success
6  03.28.2023_10.17.40  pairwise_distance            S           Success        Success  Failed Execution  Failed Execution        Success  Unimplemented  Unimplemented        Success        Success        Success
7  03.28.2023_10.17.40              rambo            S           Success        Success     Unimplemented     Unimplemented        Success  Unimplemented        Success  Unimplemented        Success        Success
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer? n/a
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

Closes #165

@ZzEeKkAa
ZzEeKkAa marked this pull request as ready for review March 23, 2023 19:38
@ZzEeKkAa ZzEeKkAa changed the title Nuke imports Remove imports from black_scholes Mar 23, 2023
@ZzEeKkAa
ZzEeKkAa marked this pull request as draft March 27, 2023 15:28
@ZzEeKkAa ZzEeKkAa changed the title Remove imports from black_scholes Remove imports from all benchmarks Mar 28, 2023
@ZzEeKkAa ZzEeKkAa self-assigned this Mar 28, 2023
@ZzEeKkAa
ZzEeKkAa marked this pull request as ready for review March 28, 2023 16:20
Pick up all the benchmarks automatically if they
match patterns. Remove imports from all benchmarks

@diptorupd diptorupd left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants