Skip to content

Update Code to 1.146.0 - #8121

Merged
code-asher merged 8 commits into
mainfrom
update/1.146.0
Nov 20, 2026
Merged

code-asher merged 8 commits into
mainfrom
update/1.146.0

Conversation

@cdrci

@cdrci cdrci commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor
  • Revert CSP hashes
  • Update Code to 1.146.0
  • Refresh Code patches
  • Update Node version
  • Regenerate CSP hashes
  • Add changelog note
  • Verify changelog

@code-asher
code-asher force-pushed the update/1.146.0 branch 3 times, most recently from c71cc51 to 7b56ac1 Compare November 13, 2026 03:28
@code-asher
code-asher marked this pull request as ready for review November 13, 2026 03:28
@code-asher
code-asher requested a review from a team as a code owner November 13, 2026 03:28
@code-asher
code-asher enabled auto-merge (squash) November 13, 2026 03:29

@code-asher code-asher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah upstream switched to pnpm...will need to refactor some things

@code-asher
code-asher force-pushed the update/1.146.0 branch 5 times, most recently from 7ae1e5d to 6b742a6 Compare November 17, 2026 00:31
@linear-code

linear-code Bot commented Nov 18, 2026

Copy link
Copy Markdown

CODE-119

npm 12 removes support for shrinkwraps.  Additionally, VS Code has
switched to pnpm and this will make generating the shrinkwraps less
straightforward.

Exact pins in the package.json would not be a sufficient replacement
since that does not cover transitive dependencies.

The recommendation for end user packages installed globally with npm
seems to be to be to bundle dependencies.

One idea would be to build for every platform and bundle them all, but
the whole reason we have the npm package is to support platforms for
which we are not building.  If we build them, we could just add a
regular release for that platform on GitHub.

So instead for each native module we would need to add rebuild commands
in the postinstall.  And ideally remove the current platform builds to
at least try keeping the tarball size down.

I am not sure it is worth the effort for what it feels like fighting
with npm, so this change does not attempt that.
Not strictly necessary since we only install production dependencies in
the postinstall, but might as well save some bytes.
@code-asher
code-asher marked this pull request as draft November 19, 2026 22:10
auto-merge was automatically disabled November 19, 2026 22:10

Pull request was converted to draft

@code-asher
code-asher changed the base branch from main to asher/shrinkwraps November 19, 2026 23:29
@code-asher
code-asher force-pushed the update/1.146.0 branch 2 times, most recently from 6bc8bd1 to 720b9a1 Compare November 20, 2026 01:57
@code-asher
code-asher marked this pull request as ready for review November 20, 2026 02:07
@code-asher
code-asher changed the base branch from asher/shrinkwraps to main November 20, 2026 02:08
@code-asher
code-asher marked this pull request as draft November 20, 2026 02:08
@code-asher
code-asher force-pushed the update/1.146.0 branch 5 times, most recently from 9612f3b to b1e66d0 Compare November 20, 2026 07:22
@code-asher
code-asher force-pushed the update/1.146.0 branch 2 times, most recently from c48e165 to 26e41ce Compare November 20, 2026 09:22
@code-asher
code-asher marked this pull request as ready for review November 20, 2026 09:33
VS Code recently switched to pnpm so various scripts needed to be
updated, and we might as well follow suite with code-server's own
dependencies.

In general this change just swaps out "npm" invocations for "pnpm" plus
any necessary flag changes to match but to call out some less obvious
changes:

1. The extensions directory no longer has a post-install script, so
   there is no need to copy one anymore.
2. When merging the remote package.json, only copy the dependencies
   since that is all we need, to avoid copying in new properties like
   packageManager.
3. Remove unused publish:npm.  It points to a nonexistent file anyway.
4. Remove publish:docker and just call the script directly, to avoid an
   npm/pnpm dependency in a job that really has no need for it.
@code-asher
code-asher merged commit 9cc1033 into main Nov 20, 2026
17 checks passed
@code-asher
code-asher deleted the update/1.146.0 branch November 20, 2026 10:38
@code-asher
code-asher deployed to release-approval November 20, 2026 11:21 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
release-approval — 72910553 Deployed Nov 20, 2026 by code-asher via Approve, tag and publish the release #561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants