Repository navigation
Update Code to 1.146.0 - #8121
Merged
Merged
Conversation
code-asher
force-pushed
the
update/1.146.0
branch
3 times, most recently
from
November 13, 2026 03:28
c71cc51 to
7b56ac1
Compare
code-asher
marked this pull request as ready for review
November 13, 2026 03:28
code-asher
approved these changes
Nov 13, 2026
code-asher
enabled auto-merge (squash)
November 13, 2026 03:29
code-asher
requested changes
Nov 13, 2026
code-asher
left a comment
Member
There was a problem hiding this comment.
ah upstream switched to pnpm...will need to refactor some things
code-asher
force-pushed
the
update/1.146.0
branch
5 times, most recently
from
November 17, 2026 00:31
7ae1e5d to
6b742a6
Compare
npm 12 removes support for shrinkwraps. Additionally, VS Code has switched to pnpm and this will make generating the shrinkwraps less straightforward. Exact pins in the package.json would not be a sufficient replacement since that does not cover transitive dependencies. The recommendation for end user packages installed globally with npm seems to be to be to bundle dependencies. One idea would be to build for every platform and bundle them all, but the whole reason we have the npm package is to support platforms for which we are not building. If we build them, we could just add a regular release for that platform on GitHub. So instead for each native module we would need to add rebuild commands in the postinstall. And ideally remove the current platform builds to at least try keeping the tarball size down. I am not sure it is worth the effort for what it feels like fighting with npm, so this change does not attempt that.
Not strictly necessary since we only install production dependencies in the postinstall, but might as well save some bytes.
code-asher
force-pushed
the
update/1.146.0
branch
from
November 19, 2026 21:59
6b742a6 to
45f1b5b
Compare
lib/vscode/remote/.npmrc no longer exists
code-asher
force-pushed
the
update/1.146.0
branch
from
November 19, 2026 22:04
45f1b5b to
3a0e7a1
Compare
code-asher
marked this pull request as draft
November 19, 2026 22:10
auto-merge was automatically disabled
November 19, 2026 22:10
Pull request was converted to draft
code-asher
force-pushed
the
update/1.146.0
branch
from
November 19, 2026 22:47
3a0e7a1 to
bf55204
Compare
code-asher
force-pushed
the
update/1.146.0
branch
2 times, most recently
from
November 20, 2026 01:57
6bc8bd1 to
720b9a1
Compare
code-asher
marked this pull request as ready for review
November 20, 2026 02:07
code-asher
marked this pull request as draft
November 20, 2026 02:08
code-asher
force-pushed
the
update/1.146.0
branch
5 times, most recently
from
November 20, 2026 07:22
9612f3b to
b1e66d0
Compare
code-asher
force-pushed
the
update/1.146.0
branch
2 times, most recently
from
November 20, 2026 09:22
c48e165 to
26e41ce
Compare
code-asher
marked this pull request as ready for review
November 20, 2026 09:33
code-asher
force-pushed
the
update/1.146.0
branch
from
November 20, 2026 10:10
26e41ce to
f439994
Compare
VS Code recently switched to pnpm so various scripts needed to be updated, and we might as well follow suite with code-server's own dependencies. In general this change just swaps out "npm" invocations for "pnpm" plus any necessary flag changes to match but to call out some less obvious changes: 1. The extensions directory no longer has a post-install script, so there is no need to copy one anymore. 2. When merging the remote package.json, only copy the dependencies since that is all we need, to avoid copying in new properties like packageManager. 3. Remove unused publish:npm. It points to a nonexistent file anyway. 4. Remove publish:docker and just call the script directly, to avoid an npm/pnpm dependency in a job that really has no need for it.
code-asher
force-pushed
the
update/1.146.0
branch
from
November 20, 2026 10:26
f439994 to
7291055
Compare
code-asher
approved these changes
Nov 20, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.