Skip to content

Stop generating shrinkwraps - #8144

Closed
code-asher wants to merge 2 commits into
mainfrom
asher/shrinkwraps
Closed

code-asher wants to merge 2 commits into
mainfrom
asher/shrinkwraps

Conversation

@code-asher

@code-asher code-asher commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

npm 12 removes support for shrinkwraps. Additionally, VS Code has
switched to pnpm and this will make generating the shrinkwraps less
straightforward, so deciding what to do with these is blocking updating VS Code and making new releases.

Exact pins in the package.json would not be a sufficient replacement
since that does not cover transitive dependencies.

The recommendation for end user packages installed globally with npm
seems to be to be to bundle dependencies.

One idea would be to build for every platform and bundle them all, but
the whole reason we have the npm package is to support platforms for
which we are not building. If we build them, we could just add a
proper regular release for that platform on GitHub instead.

So instead for each native module we would need to add rebuild commands in the postinstall. And ideally remove the current platform builds to at least try keeping the tarball size down.

I am not sure it is worth the effort for what feels like fighting
with npm, so this change does not attempt that and I am suggesting we just let npm do what it seems to want.

npm 12 removes support for shrinkwraps.  Additionally, VS Code has
switched to pnpm and this will make generating the shrinkwraps less
straightforward.

Exact pins in the package.json would not be a sufficient replacement
since that does not cover transitive dependencies.

The recommendation for end user packages installed globally with npm
seems to be to be to bundle dependencies.

One idea would be to build for every platform and bundle them all, but
the whole reason we have the npm package is to support platforms for
which we are not building.  If we build them, we could just add a
regular release for that platform on GitHub.

So instead for each native module we would need to add rebuild commands
in the postinstall.  And ideally remove the current platform builds to
at least try keeping the tarball size down.

I am not sure it is worth the effort for what it feels like fighting
with npm, so this change does not attempt that.
Not strictly necessary since we only install production dependencies in
the postinstall, but might as well save some bytes.
@code-asher
code-asher requested a review from a team as a code owner November 19, 2026 09:22
@code-asher
code-asher requested a review from a team November 19, 2026 21:55
@code-asher

Copy link
Copy Markdown
Member Author

Superseded by #8121

@code-asher code-asher closed this Nov 20, 2026
@code-asher
code-asher deleted the asher/shrinkwraps branch November 20, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant