Repository navigation
Stop generating shrinkwraps - #8144
Closed
code-asher wants to merge 2 commits into
Closed
code-asher wants to merge 2 commits into
code-asher wants to merge 2 commits into
Conversation
npm 12 removes support for shrinkwraps. Additionally, VS Code has switched to pnpm and this will make generating the shrinkwraps less straightforward. Exact pins in the package.json would not be a sufficient replacement since that does not cover transitive dependencies. The recommendation for end user packages installed globally with npm seems to be to be to bundle dependencies. One idea would be to build for every platform and bundle them all, but the whole reason we have the npm package is to support platforms for which we are not building. If we build them, we could just add a regular release for that platform on GitHub. So instead for each native module we would need to add rebuild commands in the postinstall. And ideally remove the current platform builds to at least try keeping the tarball size down. I am not sure it is worth the effort for what it feels like fighting with npm, so this change does not attempt that.
Not strictly necessary since we only install production dependencies in the postinstall, but might as well save some bytes.
Member
Author
|
Superseded by #8121 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm 12 removes support for shrinkwraps. Additionally, VS Code has
switched to pnpm and this will make generating the shrinkwraps less
straightforward, so deciding what to do with these is blocking updating VS Code and making new releases.
Exact pins in the package.json would not be a sufficient replacement
since that does not cover transitive dependencies.
The recommendation for end user packages installed globally with npm
seems to be to be to bundle dependencies.
One idea would be to build for every platform and bundle them all, but
the whole reason we have the npm package is to support platforms for
which we are not building. If we build them, we could just add a
proper regular release for that platform on GitHub instead.
So instead for each native module we would need to add rebuild commands in the postinstall. And ideally remove the current platform builds to at least try keeping the tarball size down.
I am not sure it is worth the effort for what feels like fighting
with npm, so this change does not attempt that and I am suggesting we just let npm do what it seems to want.