Skip to content

doc: add doc on when to backport V8 patches to main - #66710

Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
legendecas:v8-backport
Oct 16, 2026
Merged

nodejs-github-bot merged 6 commits into
nodejs:mainfrom
legendecas:v8-backport

Conversation

@legendecas

@legendecas legendecas commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

As part of our dependency maintenance rules (like
automated dependency updaters for security reasons),
the general rule is "don't backport individual V8 patches".

Increasing floating patches on the deps/v8 further delay the pending
V8 upgrade and increase the cost to land the upgrade in time.

The backport should only be applied to certain categories of patches,
like fixing builds, V8 API usages, security issues.

I intentionally make this rule strict as proposed in #66393.
I believe this makes the criteria more clearer in a first instinct,
without too many mental cost on determine if we should backport or not.

Refs: #66393

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Oct 13, 2026
@legendecas legendecas added the v8 engine Issues and PRs related to the V8 dependency. label Oct 13, 2026
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
@legendecas
legendecas force-pushed the v8-backport branch 3 times, most recently from ffdff3c to 6f5b7ee Compare October 14, 2026 13:45
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@legendecas legendecas added meta Issues and PRs related to the general management of the project. author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 16, 2026
@legendecas legendecas added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Oct 16, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 5926201 into nodejs:main Oct 16, 2026
30 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 5926201

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 16, 2026
@legendecas
legendecas deleted the v8-backport branch October 16, 2026 17:38
aduh95 pushed a commit that referenced this pull request Nov 12, 2026
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: #66710
Refs: #66393
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Nov 17, 2026
This workflow detects whether the PR is a V8 backport and remind
the author to wait for the next V8 major upgrade unless they can
justify the fast-tracking following the documented criteria.
It also checks if the v8_embedder_string is properly bumped.
To avoid the noise, it also allows the use of a label
`v8-backport-to-main` added at PR open time to surpress the check.

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #67436
Fixes: #66393
Refs: #66710
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation. meta Issues and PRs related to the general management of the project. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants