Repository navigation
tools: add a workflow to send reminder about v8 backports - #67436
Conversation
|
Review requested:
|
|
cc @nodejs/tsc @nodejs/v8-update |
|
I created v8-backport-to-main |
legendecas
left a comment
There was a problem hiding this comment.
is v8-backport-to-main checked any where?
This workflow detects whether the PR is a V8 backport and remind the author to wait for the next V8 major upgrade unless they can justify the fast-tracking following the documented criteria. It also checks if the v8_embedder_string is properly bumped. To avoid the noise, it also allows the use of a label `v8-backport-to-main` added at PR open time to surpress the check. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
e28c65f to
ca72873
Compare
oops, apparently I didn't stage my latest changes locally before comming it for the PR, so the commit message was out of sync of what it's supposed to do 😅 updated, this now properly checks the label and reminds the contributor about the missing version bump. PTAL. |
legendecas
left a comment
There was a problem hiding this comment.
Could we add these conditions as well to reduce false positive or duplicate comments?
node/.github/workflows/contributor-guidance.yml
Lines 18 to 21 in dadf029
Thanks for the suggestion, added. |
|
Landed in 16ea1d2 |
This workflow detects whether the PR is a V8 backport and remind the author to wait for the next V8 major upgrade unless they can justify the fast-tracking following the documented criteria. It also checks if the v8_embedder_string is properly bumped. To avoid the noise, it also allows the use of a label
v8-backport-to-mainadded at PR open time to surpress the check.Fixes: #66393
Refs: #66710