Skip to content

tools: add a workflow to send reminder about v8 backports - #67436

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
joyeecheung:v8-deps-reminder
Nov 17, 2026
Merged

nodejs-github-bot merged 2 commits into
nodejs:mainfrom
joyeecheung:v8-deps-reminder

Conversation

@joyeecheung

Copy link
Copy Markdown
Member

This workflow detects whether the PR is a V8 backport and remind the author to wait for the next V8 major upgrade unless they can justify the fast-tracking following the documented criteria. It also checks if the v8_embedder_string is properly bumped. To avoid the noise, it also allows the use of a label v8-backport-to-main added at PR open time to surpress the check.

Fixes: #66393
Refs: #66710

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 12, 2026
@joyeecheung

Copy link
Copy Markdown
Member Author

cc @nodejs/tsc @nodejs/v8-update

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joyeecheung

Copy link
Copy Markdown
Member Author

I created v8-backport-to-main

@panva panva left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@legendecas legendecas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is v8-backport-to-main checked any where?

This workflow detects whether the PR is a V8 backport and remind
the author to wait for the next V8 major upgrade unless they can
justify the fast-tracking following the documented criteria.
It also checks if the v8_embedder_string is properly bumped.
To avoid the noise, it also allows the use of a label
`v8-backport-to-main` added at PR open time to surpress the check.

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
@joyeecheung

joyeecheung commented Nov 13, 2026 •

Copy link
Copy Markdown
Member Author

is v8-backport-to-main checked any where?

oops, apparently I didn't stage my latest changes locally before comming it for the PR, so the commit message was out of sync of what it's supposed to do 😅 updated, this now properly checks the label and reminds the contributor about the missing version bump. PTAL.

@legendecas @mcollina @bnb @panva

@legendecas legendecas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add these conditions as well to reduce false positive or duplicate comments?

if: >-
github.run_attempt == 1 &&
github.repository == 'nodejs/node' &&
github.event.pull_request.user.type != 'Bot' &&

@joyeecheung

Copy link
Copy Markdown
Member Author

Could we add these conditions as well to reduce false positive or duplicate comments?

Thanks for the suggestion, added.

@legendecas legendecas added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 16, 2026
@joyeecheung joyeecheung added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Nov 17, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 16ea1d2 into nodejs:main Nov 17, 2026
24 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 16ea1d2

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Freezing deps/v8 on the main branch during major V8 upgrades

7 participants