Repository navigation
fix(search): read the full text of Slack canvases and files instead of the preview - #10082
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The PR appears safe to merge; no new actionable issues were found. SummarySlack file reads now return full text for supported Slack-hosted files, with bounded downloads and a preview fallback.
Reviews (3) · Last reviewed commit: "fix(search): let a UTF-8 byte-order mark..." · Reviewed by Greptile |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 11 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
files.slack.com, never a remote file's own URL; the client's sibling-host option (previously Sheets-only) now covers both, each locked to its own provider originslack.file_previewdiagnostic signal on every read that returns the previewdrive-content.tsinto sharedfile-text.ts; Drive behavior is unchangedfiles:readgrantType of Change
Testing
slack.test.ts: canvas, text, PDF full-text reads; token never leaves Slack's file host (foreign host,http:, external file); preview + reason on denial, redirect, timeout; caller abort propagates; oversize and unsupported files skip the download; MIME parameters/case normalized. Each guard reverted and watched go red.http.test.ts: sibling hosts only reachable from their own provider originlib/sim-search/live+lib/knowledge/searchsuites pass; biome; egress-boundary, organization-egress, boundaries, comment-hygiene, file-names, explicit-any, utils, test-patterns, import-specifiers, source-text audits passChecklist
test-auditauthoring gate)