Repository navigation
fix(search): follow Slack's file download redirects without carrying the token off its file host - #10084
Merged
Conversation
…the token off its file host
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues remain. SummarySlack file downloads may follow up to three redirects, but every hop must stay on
|
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxRedirects: 0files.slack.com(same origin, so anhttp:downgrade or lookalike host is refused too) via secure fetch's existingassertRedirectTargethook. Every other native request, including Sheets, still follows noneNativeSearchError, so the read keeps the preview and names the host it was sent tourl_privatedownloaders, which already follow redirectsType of Change
Testing
http.test.ts: the file-host redirect guard (the real closure passed to secure fetch) accepts a same-host hop and refuses the sign-in page, a lookalike host and anhttp:downgrade; Sheets keeps zero redirects and no guard. Comparing hostname instead of origin, dropping the guard, or letting Sheets follow redirects each turn a test redpinned-redirect-replay.server.test.tslib/sim-search/live+lib/knowledge/searchsuites pass; biome; egress-boundary, organization-egress, boundaries, comment-hygiene, test-patterns audits passChecklist
test-auditauthoring gate)