Repository navigation
fix(lint): check table json inputs that hold bare block references - #10146
Conversation
Table input checks JSON-parsed raw field values, so a reference written
outside a JSON string (e.g. {"count": <start.count>} or a whole-field
<start.row>), which resolves to valid JSON at runtime, made the whole
check end with an 'Invalid JSON' could-not-complete note. Quote those
references in the lint-local copy before the Table block's own parser
runs, so literal keys are still checked and the references reach the
existing runtime-resolution notes.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
[Low impact] The changes appear safe to merge. SummaryTable lint now defers inputs with more than six bare references instead of stopping checks on unrelated literal inputs.
Reviews (4) · Last reviewed commit: "fix(lint): defer reference fields past t..." · Reviewed by Greptile |
…shape checks A quoted reference can still fail the Table block's shape validation, for example a filter in-list or a whole-field filter. Retry the transform without those runtime-only fields and note them as runtime-resolved, so the remaining literal inputs are still checked. Filter cases now run against the registered TableV2Block.
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Try string and one-item-list placeholders per reference instead of dropping any field that holds one, so in-list references are still checked and an invalid literal condition still reports. Only a field that is a single whole reference is deferred to runtime.
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Above the search bound an all-string or all-list fallback cannot tell a literal error from a reference type mismatch, so leave the reference-bearing fields out and keep checking the other inputs instead of ending the table check.
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
{"count": <start.count>},[<start.first>, {...}], or a whole-field<start.row>) failed withInvalid JSON ... Unrecognized token '<'and the check reported "could not complete" — even though the reference resolves to JSON at runtime and the block runs finefindWorkflowReferenceTokens) in its local copy of the paramsunquoted-json-stringfindingType of Change
Testing
read-workflow-lint-tables.test.ts: bare refs in row data and filter values, whole-field refs for data/rows, a bare ref inside a rows array, refs inside JSON strings left untouched, malformed JSON with a ref still reportedread-workflow-lint-tables,read-workflow-lint-refs,read-workflow-lint-agent-toolstest files: 63/63 pass; biome clean on changed filesChecklist
test-auditauthoring gate)