Skip to content

fix(lint): use structural placeholders for table input references - #10149

Merged
waleedlatif1 merged 3 commits into
stagingfrom
fix/lint-table-structural-placeholders
Nov 18, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
fix/lint-table-structural-placeholders

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Follow-up to fix(lint): check table json inputs that hold bare block references #10146: replaces the bounded placeholder-combination search in the workflow lint's Table input check with one structural pass
  • Every bare block reference in a Table JSON input is quoted. Refs used as an in/nin value become one-item lists, and whole-condition refs inside all/any groups are left out while the group keeps a literal member. The Table transform then runs once
  • Only if that fails are whole-reference fields (e.g. <start.filter>) left out for one final attempt, whose error is reported. The literal error is shown rather than a note about the deferred field
  • Fixes: row data with many bare refs no longer skips the unknown-column check; malformed row data beside a whole-field filter ref is reported as the data error; deferred whole-field row data is no longer called "not a static object"

Type of Change

  • Bug fix

Testing

  • read-workflow-lint-tables.test.ts: new cases for 7 bare refs in row data (with and without a filter ref), a whole-condition ref in a group, malformed data beside a whole-field filter ref, and deferred whole-field data. All 5 fail on the previous code and pass now. The test that locked in the old reference bound was removed; the "still reports real errors" cases are kept
  • read-workflow-lint-tables, read-workflow-lint-refs, read-workflow-lint-agent-tools: 71/71 pass; biome clean

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Quote every bare reference, turn in/nin condition values into one-item lists and drop whole-condition references from all/any groups, then run the Table transform once. Only if that fails are whole-reference fields left out for one final attempt, whose error is reported. This removes the reference-count bound that skipped row data with many references, blames the literal error rather than a deferred field, and stops deferred row data from being called non-static.
@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 18, 2026 5:39am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The latest change appears safe to merge; the remaining row-check gap is non-blocking.

Summary

The PR replaces repeated Table input checks with one structural pass over references. The latest update preserves row objects that contain additional literal keys.

  • Table lint keeps checking literal fields beside runtime references.

No new actionable issues were found in the changes since the previous review.

Reviews (3) · Last reviewed commit: "fix(lint): treat only single-key all/any..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

…filter groups

Give each bare reference occurrence its own placeholder so a quoted value with the same text is left unchanged, rebuild objects with Object.fromEntries so a __proto__ row key survives, and treat a filter whose root group holds only references as runtime-only so the remaining inputs are still checked.
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit f51dad7 into staging Nov 18, 2026
81 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/lint-table-structural-placeholders branch November 18, 2026 05:57

This branch was previously deployed

1 inactive deployment
Preview — d3129d19 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant