Repository navigation
fix(lint): use structural placeholders for table input references - #10149
Conversation
Quote every bare reference, turn in/nin condition values into one-item lists and drop whole-condition references from all/any groups, then run the Table transform once. Only if that fails are whole-reference fields left out for one final attempt, whose error is reported. This removes the reference-count bound that skipped row data with many references, blames the literal error rather than a deferred field, and stops deferred row data from being called non-static.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Low impact] The latest change appears safe to merge; the remaining row-check gap is non-blocking. SummaryThe PR replaces repeated Table input checks with one structural pass over references. The latest update preserves row objects that contain additional literal keys.
No new actionable issues were found in the changes since the previous review. Reviews (3) · Last reviewed commit: "fix(lint): treat only single-key all/any..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…filter groups Give each bare reference occurrence its own placeholder so a quoted value with the same text is left unchanged, rebuild objects with Object.fromEntries so a __proto__ row key survives, and treat a filter whose root group holds only references as runtime-only so the remaining inputs are still checked.
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
in/ninvalue become one-item lists, and whole-condition refs insideall/anygroups are left out while the group keeps a literal member. The Table transform then runs once<start.filter>) left out for one final attempt, whose error is reported. The literal error is shown rather than a note about the deferred fieldType of Change
Testing
read-workflow-lint-tables.test.ts: new cases for 7 bare refs in row data (with and without a filter ref), a whole-condition ref in a group, malformed data beside a whole-field filter ref, and deferred whole-field data. All 5 fail on the previous code and pass now. The test that locked in the old reference bound was removed; the "still reports real errors" cases are keptread-workflow-lint-tables,read-workflow-lint-refs,read-workflow-lint-agent-tools: 71/71 pass; biome cleanChecklist
test-auditauthoring gate)