Skip to content

fix(lint): note a table filter made only of references as not checked - #10158

Closed
waleedlatif1 wants to merge 1 commit into
stagingfrom
fix/lint-runtime-table-fields
Closed

waleedlatif1 wants to merge 1 commit into
stagingfrom
fix/lint-runtime-table-fields

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • A Table filter, sort, or row field made only of bare references (e.g. {"all":[<start.a>,<start.b>]}) now goes to the Table transform as its own text in one string, the same shape a whole-field reference already takes
  • Before, the group kept its record shape with string members, so it passed as a static query, named no columns, and lint said nothing about it going unchecked. It now gets the existing "not a static query object; its column references were not checked" note
  • Follow-up to fix(lint): use structural placeholders for table input references #10149, from review of the release PR

Type of Change

  • Bug fix

Testing

  • New case in read-workflow-lint-tables.test.ts fails on the pre-fix code and passes with the fix
  • read-workflow-lint-tables.test.ts and read-workflow-lint-refs.test.ts: 58/58 passing
  • biome on the changed files; type-check, audits, and the full suite run in CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 18, 2026 5:21pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Low impact] The change is limited to Table checks in workflow lint reports.

This appears safe to merge, with a non-blocking issue in checks for single-key row data.

Findings

  1. P2 Literal row keys go unchecked ▶

Summary

This PR adds an unchecked-input note for Table filters made entirely of references.

  • Table linting now flags reference-only filters as unchecked.

Reviews (1) · Last reviewed commit: "fix(lint): note a table filter made only..." · Reviewed by Greptile

)
}
return { value: JSON.stringify(adapt(parsed)), runtimeOnly: isDynamic(parsed) }
if (isDynamic(parsed)) return { value: JSON.stringify(json), runtimeOnly: true }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Literal row keys go unchecked. This helper also receives row data. For insert_row with data: '{"all":[<start.values>]}', isDynamic returns true even though all is a literal column name. The new branch turns the object into a string, so inspectRow reports that the row is not static instead of checking whether all exists. Previously it reported the missing column. Limit group-only deferral to filter inputs and keep row objects intact; add a case with just one all or any key.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Confidence score: 4/5

  • read-workflow-lint.ts can misclassify valid row data in columns named all or any as predicate groups. Preserve adapted row objects, or limit the conversion to filter and sort inputs.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/sim/lib/workflows/application/read-workflow-lint.ts">

<violation number="1" location="apps/sim/lib/workflows/application/read-workflow-lint.ts:344">
P2: This misclassifies valid row data for a column named `all` or `any` as a runtime-only predicate group. Preserve the adapted object for row fields, or apply this whole-value string conversion only to filter/sort inputs, so row keys remain linted.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

)
}
return { value: JSON.stringify(adapt(parsed)), runtimeOnly: isDynamic(parsed) }
if (isDynamic(parsed)) return { value: JSON.stringify(json), runtimeOnly: true }

@cubic-dev-ai cubic-dev-ai Bot Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: This misclassifies valid row data for a column named all or any as a runtime-only predicate group. Preserve the adapted object for row fields, or apply this whole-value string conversion only to filter/sort inputs, so row keys remain linted.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At apps/sim/lib/workflows/application/read-workflow-lint.ts, line 344:

<comment>This misclassifies valid row data for a column named `all` or `any` as a runtime-only predicate group. Preserve the adapted object for row fields, or apply this whole-value string conversion only to filter/sort inputs, so row keys remain linted.</comment>

<file context>
@@ -340,7 +341,8 @@ function withReferencePlaceholders(json: string): { value: string; runtimeOnly:
     )
   }
-  return { value: JSON.stringify(adapt(parsed)), runtimeOnly: isDynamic(parsed) }
+  if (isDynamic(parsed)) return { value: JSON.stringify(json), runtimeOnly: true }
+  return { value: JSON.stringify(adapt(parsed)), runtimeOnly: false }
 }
</file context>
Fix with cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

Closing. Against the real table_v2 transform, a filter group made only of references fails validatePredicateShape, so lint already takes the retry path and notes filterInput as resolved at runtime and not checked. The gap only showed with the legacy TableBlock the lint tests use in its place, and this change would stop checking a row column named all or any (both reviewers caught that).

@waleedlatif1
waleedlatif1 deleted the fix/lint-runtime-table-fields branch November 18, 2026 18:07

This branch was previously deployed

1 inactive deployment
Preview — 23f4bc54 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant