Repository navigation
fix(lint): note a table filter made only of references as not checked - #10158
waleedlatif1 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Low impact] The change is limited to Table checks in workflow lint reports. This appears safe to merge, with a non-blocking issue in checks for single-key row data. Findings
SummaryThis PR adds an unchecked-input note for Table filters made entirely of references.
Reviews (1) · Last reviewed commit: "fix(lint): note a table filter made only..." · Reviewed by Greptile |
| ) | ||
| } | ||
| return { value: JSON.stringify(adapt(parsed)), runtimeOnly: isDynamic(parsed) } | ||
| if (isDynamic(parsed)) return { value: JSON.stringify(json), runtimeOnly: true } |
There was a problem hiding this comment.
Literal row keys go unchecked. This helper also receives row data. For
insert_row with data: '{"all":[<start.values>]}', isDynamic returns true even though all is a literal column name. The new branch turns the object into a string, so inspectRow reports that the row is not static instead of checking whether all exists. Previously it reported the missing column. Limit group-only deferral to filter inputs and keep row objects intact; add a case with just one all or any key.
There was a problem hiding this comment.
1 issue found across 2 files
Confidence score: 4/5
read-workflow-lint.tscan misclassify valid row data in columns namedalloranyas predicate groups. Preserve adapted row objects, or limit the conversion to filter and sort inputs.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/lib/workflows/application/read-workflow-lint.ts">
<violation number="1" location="apps/sim/lib/workflows/application/read-workflow-lint.ts:344">
P2: This misclassifies valid row data for a column named `all` or `any` as a runtime-only predicate group. Preserve the adapted object for row fields, or apply this whole-value string conversion only to filter/sort inputs, so row keys remain linted.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
| ) | ||
| } | ||
| return { value: JSON.stringify(adapt(parsed)), runtimeOnly: isDynamic(parsed) } | ||
| if (isDynamic(parsed)) return { value: JSON.stringify(json), runtimeOnly: true } |
There was a problem hiding this comment.
P2: This misclassifies valid row data for a column named all or any as a runtime-only predicate group. Preserve the adapted object for row fields, or apply this whole-value string conversion only to filter/sort inputs, so row keys remain linted.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At apps/sim/lib/workflows/application/read-workflow-lint.ts, line 344:
<comment>This misclassifies valid row data for a column named `all` or `any` as a runtime-only predicate group. Preserve the adapted object for row fields, or apply this whole-value string conversion only to filter/sort inputs, so row keys remain linted.</comment>
<file context>
@@ -340,7 +341,8 @@ function withReferencePlaceholders(json: string): { value: string; runtimeOnly:
)
}
- return { value: JSON.stringify(adapt(parsed)), runtimeOnly: isDynamic(parsed) }
+ if (isDynamic(parsed)) return { value: JSON.stringify(json), runtimeOnly: true }
+ return { value: JSON.stringify(adapt(parsed)), runtimeOnly: false }
}
</file context>
|
Closing. Against the real |
Summary
{"all":[<start.a>,<start.b>]}) now goes to the Table transform as its own text in one string, the same shape a whole-field reference already takesType of Change
Testing
read-workflow-lint-tables.test.tsfails on the pre-fix code and passes with the fixread-workflow-lint-tables.test.tsandread-workflow-lint-refs.test.ts: 58/58 passingChecklist
test-auditauthoring gate)