Repository navigation
fix(lint): note a table filter made only of references as not checked #10158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -295,8 +295,9 @@ function normalizeTableInputs( | |
| * with the same text is never mistaken for one. A quoted reference fits row values and most | ||
| * filter values; the value of an `in`/`nin` condition must be a list, so it becomes a one-item | ||
| * list, and a condition or group made only of references has no literal part, so it is left out | ||
| * of an `all`/`any` group that keeps a literal member. `runtimeOnly` marks a field whose whole | ||
| * value is such a reference or group. | ||
| * of an `all`/`any` group that keeps a literal member. A field whose whole value is such a | ||
| * reference or group has nothing to check before runtime, so its text becomes one JSON string, | ||
| * the same shape a whole-field reference takes, and `runtimeOnly` marks it. | ||
| */ | ||
| function withReferencePlaceholders(json: string): { value: string; runtimeOnly: boolean } { | ||
| const nonce = generateShortId() | ||
|
|
@@ -340,7 +341,8 @@ function withReferencePlaceholders(json: string): { value: string; runtimeOnly: | |
| }) | ||
| ) | ||
| } | ||
| return { value: JSON.stringify(adapt(parsed)), runtimeOnly: isDynamic(parsed) } | ||
| if (isDynamic(parsed)) return { value: JSON.stringify(json), runtimeOnly: true } | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: This misclassifies valid row data for a column named Prompt for AI agents |
||
| return { value: JSON.stringify(adapt(parsed)), runtimeOnly: false } | ||
| } | ||
|
|
||
| function replaceBareReferences(json: string, placeholder: (reference: string) => string): string { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
insert_rowwithdata: '{"all":[<start.values>]}',isDynamicreturns true even thoughallis a literal column name. The new branch turns the object into a string, soinspectRowreports that the row is not static instead of checking whetherallexists. Previously it reported the missing column. Limit group-only deferral to filter inputs and keep row objects intact; add a case with just onealloranykey.