Repository navigation
improvement(mothership): keep workflow test-run results inside the agent window - #10147
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
[Medium impact] The follow-up changes appear safe to merge. SummaryKeeps workflow test-run results inside the agent window by replacing bulky echoed data with log pointers and shortening large final outputs.
No new actionable issues found in the follow-up changes. Reviews (2) · Last reviewed commit: "fix(mothership): measure the run result ..." · Reviewed by Greptile |
…n and fit the preview
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Summary
logs get <id> --tracepointers, largest first, so pass/fail, the failing block's error, and each block's name/status stay inline instead of the whole result spilling behind a paged readselected values are untouched; the existing projection-cap bounding still runs first for secret-walked resultssim workflows runprints) now listerror, timings andexecutionTimeoutSecondsbeforeoutput/blockOutputs, matchingruns get, so a reader that keeps only the head of a large run still sees why it failed. Same fields, only key order changedType of Change
Testing
run-workflow-result-budget.test.ts: new/rewritten cases for fitting a failed run in the window, previewing an oversized output without a secret, and a secret-length-independent pointer with one. All four fail on the pre-change coderoute.test.ts: assertserroranddurationMsprecedeoutput; fails on the old key orderbun run --cwd apps/sim test app/api/v2/workflows/ lib/mothership/tools lib/mothership/request/tools(80 files, 1096 tests); biome on changed files. Full type-check/audits left to CIChecklist
test-auditauthoring gate)