Repository navigation
fix(mothership): cut oversized run errors after projection and collapse long block runs - #10150
Merged
Merged
Conversation
…se long block runs
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryThis PR keeps oversized workflow results easier for the agent to read by shortening errors and collapsing long block histories.
No actionable issues found. Reviews (1) · Last reviewed commit: "fix(mothership): cut oversized run error..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #10147, which held run_* results to the agent's 16K window but never cut error strings.
…[same as the run error]data.error, per-blockerror) over 1,500 chars keep their head plus alogs get <id> --tracepointer. While a secret is active the text is projected first and the projection is cut, so a cut can only fall inside a{{NAME}}, never a secretboundRunResultForModelnow returns{ data, error }so both callers send the bounded errorType of Change
Testing
run-workflow-result-budget.test.ts: new cases for a 30K HTML block error with a secret straddling the cut, and a 400-iteration loop with one failure; updated the dedupe and error-cap expectations. The new and updated cases fail on the previous headbun run --cwd apps/sim test lib/mothership/tools lib/mothership/request/tools(929 tests); type-check via the pre-push hookChecklist
test-auditauthoring gate)