Repository navigation
fix(integrations): reject invalid kalshi order flags and anchor the arxiv link match - #10186
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Critical impact] The PR appears safe to merge; no actionable issues were found. SummaryTightens Kalshi order flags and arXiv link parsing without changing the documented inputs.
Reviews (1) · Last reviewed commit: "fix(integrations): reject invalid kalshi..." · Reviewed by Greptile |
This was referenced Nov 18, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two release blockers for #10155:
trueintofalse, so a typo liketureplaced the order without the requested restriction. A flag now accepts only true or false (trimmed, case-insensitive, real booleans too); blank still sends nothing, and anything else fails with an error naming the field. The block's dropdowns only produce blank ortrue, so saved blocks send exactly what they did before. Follow-up to cubic's finding on fix(integrations): close follow-ups from the integration validation audits #10183.arxiv.org/abs/anywhere in the input (CodeQL "Incomplete regular expression for hostnames"). The paper ID is now taken from a link only when it is an http(s) URL whose host isarxiv.orgor a subdomain and whose path starts with/abs/or/pdf/; query, fragment and.pdfare stripped. Scheme-lessarxiv.org/...links are still accepted. Any other input is treated as a bare ID, as before.Backward compatible: bare IDs,
absandpdflinks,www./export.subdomains, links with a query or fragment, and scheme-less links all resolve as before. Regression tests for both fail on current staging.Release notes
Kalshi
TRUEand other casings are now read as true.arXiv
arxiv.org/abs/are no longer read as arXiv links.