Skip to content

fix(integrations): reject invalid kalshi order flags and anchor the arxiv link match - #10186

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/validate-release-fixes
Nov 18, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/validate-release-fixes

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Two release blockers for #10155:

  • Kalshi: order flags (Post Only, Reduce Only, Cancel Order on Pause) turned any non-blank value other than true into false, so a typo like ture placed the order without the requested restriction. A flag now accepts only true or false (trimmed, case-insensitive, real booleans too); blank still sends nothing, and anything else fails with an error naming the field. The block's dropdowns only produce blank or true, so saved blocks send exactly what they did before. Follow-up to cubic's finding on fix(integrations): close follow-ups from the integration validation audits #10183.
  • arXiv Get Paper: the link unwrapping matched arxiv.org/abs/ anywhere in the input (CodeQL "Incomplete regular expression for hostnames"). The paper ID is now taken from a link only when it is an http(s) URL whose host is arxiv.org or a subdomain and whose path starts with /abs/ or /pdf/; query, fragment and .pdf are stripped. Scheme-less arxiv.org/... links are still accepted. Any other input is treated as a bare ID, as before.

Backward compatible: bare IDs, abs and pdf links, www./export. subdomains, links with a query or fragment, and scheme-less links all resolve as before. Regression tests for both fail on current staging.

Release notes

Kalshi

  • Create Order now rejects a Post Only, Reduce Only or Cancel Order on Pause value other than true or false, instead of silently placing the order without the restriction. TRUE and other casings are now read as true.

arXiv

  • Get Paper only unwraps links that actually point to arxiv.org; other URLs that merely contain arxiv.org/abs/ are no longer read as arXiv links.

@vercel

vercel Bot commented Nov 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 18, 2026 10:18pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Critical impact] The PR appears safe to merge; no actionable issues were found.

Summary

Tightens Kalshi order flags and arXiv link parsing without changing the documented inputs.

  • Kalshi Create Order rejects malformed order flags.
  • Get Paper unwraps links only when they point to arxiv.org.

Reviews (1) · Last reviewed commit: "fix(integrations): reject invalid kalshi..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit e9d4c1f into staging Nov 18, 2026
60 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/validate-release-fixes branch November 18, 2026 22:20

This branch was previously deployed

1 inactive deployment
Preview — 1dbed6c8 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant