Skip to content

fix(integrations): keep saved output references valid and encode firecrawl job ids - #10187

Merged
waleedlatif1 merged 4 commits into
stagingfrom
fix/release-fixes-followup
Nov 18, 2026
Merged

waleedlatif1 merged 4 commits into
stagingfrom
fix/release-fixes-followup

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Release hardening and compatibility follow-ups to #10186:

  • arXiv Get Paper: a bare ID's query or fragment is now stripped with split(/[?#]/, 1)[0] instead of the /[?#].*$/ replace, which static analysis can flag as a polynomial regex. Same result for real IDs.
  • Firecrawl: the agent, crawl, extract and batch scrape status polls now URL-encode the job ID in the path, as the cancel requests and the standalone status tools already do. Firecrawl job IDs are UUIDs, so the requests sent are unchanged. A start response with no job ID now fails at once (agent and extract throw in transformResponse, as batch scrape already did; crawl and batch scrape check before polling) instead of polling /undefined until the time limit.
  • Tavily Map and Ketch Get Consent: the corrected output schemas (Map results as strings, Get Consent vendors as a list of strings) made references that validated in production, such as <tavily.results[0].url> and <ketch.vendors.someVendor>, fail the run with an invalid-field error instead of resolving empty. Their item nodes are now marked open, the existing schema marker that accepts any sub-path, so every reference that validated before still does while the accurate shapes stay documented. open is added to the tool output types; the executor already honors it. It is an internal reference-validation hint, so the v2 catalog projection strips it at every depth and the public contract is unchanged.
  • Kalshi Cancel Order and Amend Order (V1 and V2): new optional subaccount param, sent as the subaccount query param that Kalshi's spec gives CancelOrderV2 and AmendOrderV2. Without it, an order placed on a numbered subaccount through Create Order V2 could not be cancelled or amended. The order read that precedes a cancel without a ticker or an amend without count and price sends no subaccount, because GetOrder takes none. The signature still covers the path only. The block has no subaccount field for create, so this is a tool param only (agents and API callers).
  • Path segments that production interpolated raw (Qdrant fetch/upsert points, Zep, Pinecone search/upsert text): a new stripTabsAndNewlines option of safeUrlPathSegment removes tabs, carriage returns and newlines before encoding, as the URL parser removed them from the raw URL. Only those call sites set it; callers that already encoded the ID in production (Elasticsearch, Qdrant search) keep the exact ID. An ID like coll\n from an LLM output resolves to coll again instead of a 404 on coll%0A. Spaces are still encoded, and blank and dot-segment values are still rejected (including after the removal).

Backward compatible: the only new param is Kalshi's optional subaccount, and leaving it empty sends exactly the request sent before. Other request shapes are unchanged, and every output reference that validated in production still validates. A test runs isPathInSchema against the real Tavily Map and Ketch Get Consent outputs with the production-era paths; it fails on current staging.

Release notes

Qdrant, Zep and Pinecone

  • IDs that end in a newline or contain a tab (common when the ID comes from an LLM block) work again instead of returning not found.

Kalshi

  • Cancel Order and Amend Order accept an optional subaccount, so orders placed on a numbered subaccount can be cancelled and amended.

Tavily

  • Map: workflows that reference a field under a mapped result (for example results[0].url) keep running instead of failing on an invalid reference.

Ketch

  • Get Consent: workflows that reference a field under vendors keep running instead of failing on an invalid reference.

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 18, 2026 11:01pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Critical impact] The PR appears safe to merge; no new blocking issues were found.

Summary

This PR preserves saved output references, hardens Firecrawl polling, adds Kalshi subaccount support, and restores how several integrations treat tabs and newlines in IDs.

  • Kalshi order tools can cancel or amend orders on numbered subaccounts.
  • Saved paths into Tavily Map results and Ketch vendor lists keep validating.
  • Firecrawl job polls encode IDs and stop when a start response has no ID.
  • Qdrant, Zep, and Pinecone paths trim line breaks from IDs.
  • Bare arXiv IDs still drop query and fragment text.

No new actionable issues found.

Reviews (6) · Last reviewed commit: "fix(integrations): strip url control cha..." · Reviewed by Greptile

Comment thread apps/sim/tools/firecrawl/crawl.ts Resolved
@waleedlatif1 waleedlatif1 changed the title fix(integrations): encode firecrawl poll job ids and split arxiv bare ids without a regex tail fix(integrations): release hardening for arxiv, firecrawl, tavily map and ketch consent Nov 18, 2026
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1
waleedlatif1 force-pushed the fix/release-fixes-followup branch from 9e0cbdd to 5f8335b Compare November 18, 2026 22:27
@waleedlatif1 waleedlatif1 changed the title fix(integrations): release hardening for arxiv, firecrawl, tavily map and ketch consent fix(integrations): keep saved output references valid and encode firecrawl job ids Nov 18, 2026
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 18 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/kalshi/orders.ts Resolved
@waleedlatif1
waleedlatif1 force-pushed the fix/release-fixes-followup branch from 01b1998 to c3299ab Compare November 18, 2026 22:50
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 21 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/url-path.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 31 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 796c04a into staging Nov 18, 2026
82 of 83 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/release-fixes-followup branch November 18, 2026 23:05

This branch was previously deployed

1 inactive deployment
Preview — eafa781a Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant