Repository navigation
build: serve the 2.0 docs as docs.solidjs.com - #1699
Merged
Merged
Conversation
Production builds set SITE_URL to https://docs.solidjs.com, so the sitemap and llms files use it and the noindex header for non-canonical hosts is not written. v2.solidjs.com 301s to the same path on docs.solidjs.com. Merge only once docs.solidjs.com points at this site. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWNxvzLd4SQ3p3kgdA1
|
|
✅ Deploy Preview for solid-docs-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1 of 2 tasks
The AI tools page, the llms-small primer and the sample diagnostic in the diagnostics index name docs.solidjs.com, the host they will be served from once this PR lands. v2.solidjs.com redirects there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWNxvzLd4SQ3p3kgdA1
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWNxvzLd4SQ3p3kgdA1
ryansolid
marked this pull request as ready for review
November 16, 2026 21:25
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ryan · project thread
Description(required)
Merge only once docs.solidjs.com points at this Netlify site. Until then, the redirect would send v2.solidjs.com visitors to the 1.x docs.
When
SITE_URLis unset, the build falls back toDEPLOY_PRIME_URL. The site then treats itself as non-canonical: every page getsX-Robots-Tag: noindex, and the sitemap and llms files use the Netlify host. If docs.solidjs.com became an alias of this site without this change, Google would drop docs.solidjs.com from its index.netlify.toml[context.production.environment] SITE_URL = "https://docs.solidjs.com". Production builds no longer write the noindex header, and their sitemap,llms.txt,llms-full.txtandllms-small.txtuse docs.solidjs.com URLs. Deploy previews keep their own URL and the noindex header.https://v2.solidjs.com/*redirects (301) to the same path on docs.solidjs.com. Solid's dev warnings (diagnostics links) and JSDoc@descriptionlinks point at v2.solidjs.com, so those links keep working and land on the canonical page.Agent-facing text
scripts/extract-diagnostics.mjs) now name docs.solidjs.com.dev.mdxstill shows v2.solidjs.com, because it comes from solid's JSDoc. It updates with the nextsync:refafter solid's links move.Still to do at the switch: the Overview note links the 1.x docs at docs.solidjs.com. It needs the 1.x site's new address, which has not been decided yet.
Checked:
SITE_URL=https://docs.solidjs.com pnpm buildwrites no_headersfile, and all llms.txt links and sitemap<loc>s use docs.solidjs.com.prettier --checkpasses.Related issues & labels
🤖 Generated with Claude Code
https://claude.ai/code/session_0117BoWNxvzLd4SQ3p3kgdA1