Repository navigation
Conversation
docs.solidjs.com now serves the 2.0 docs, so the sitemap and Orama search results pointed at pages that return 404.
|
|
1 of 2 tasks
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description(required)
The Solid 1 site now lives at v1.solidjs.com, and docs.solidjs.com serves the 2.0 docs (#1699). This branch still builds every absolute URL with docs.solidjs.com, so the v1 sitemap at https://v1.solidjs.com/sitemap.xml lists pages that now return 404.
siteUrlinvite.config.tsishttps://v1.solidjs.com, so the sitemap and other absolute URLs from SolidBase use the v1 host.scripts/sync-orama.mjsindexes pages underhttps://v1.solidjs.com/${path}, so search results on the v1 site stop pointing at docs.solidjs.com. This PR changes an.mdxfile, so merging it triggers theSync Oramaworkflow and reindexes v1.lazylink in the SolidStart v2 CSS page is relative, like the other links to that page.The
<Base>anduseHeadreference examples still showhttps://docs.solidjs.com/as sample values and are unchanged.Verification:
pnpm buildpasses.dist/sitemap.xmllists onlyhttps://v1.solidjs.com/...URLs (0 docs.solidjs.com entries), and the only built HTML that still contains docs.solidjs.com is the<Base>example page. Prettier passes on the changed files.Related issues & labels
🤖 Generated with Claude Code