Skip to content

Getting negative non-finished rates when using finished(:reset => false) - #83

Merged
andrew merged 1 commit into
splitrb:masterfrom
philnash:stop-overwriting-finished-values
Nov 7, 2012
Merged

andrew merged 1 commit into
splitrb:masterfrom
philnash:stop-overwriting-finished-values

Conversation

@philnash

@philnash philnash commented Nov 7, 2012

Copy link
Copy Markdown
Contributor

During testing we've found that if users go through a test that is set to not reset (finished(experiment_name, :reset => false)) and then go through again that the completion rate is incremented even though the participation rate isn't.

It turned out that the clean_old_versions method was removing the key experiment_name:version:finished key from the session.

This fix makes clean_old_versions ignore the current finished experiment as well as the current experiment.

@andrew

andrew commented Nov 7, 2012

Copy link
Copy Markdown
Member

Nice spot, don't worry about travis, it's broken on jruby for some unknown reason.

andrew added a commit that referenced this pull request Nov 7, 2012
Getting negative non-finished rates when using finished(:reset => false)
@andrew
andrew merged commit 43c716b into splitrb:master Nov 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants