Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/split/helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ def clean_old_versions(experiment)

def old_versions(experiment)
if experiment.version > 0
ab_user.keys.select { |k| k.match(Regexp.new(experiment.name)) }.reject { |k| k == experiment.key }
ab_user.keys.select { |k| k.match(Regexp.new(experiment.name)) }.
reject { |k| k.match(Regexp.new("^#{experiment.key}(:finished)?$")) }
else
[]
end
Expand Down
9 changes: 9 additions & 0 deletions spec/helper_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,15 @@
button_size_alt = Split::Alternative.new(button_size, 'button_size')
button_size_alt.participant_count.should eql(1)
end

it "should not over-write a finished key when an experiment is on a later version" do
experiment = Split::Experiment.find_or_create('link_color', 'blue', 'red')
experiment.increment_version
session[:split] = { experiment.key => 'blue', experiment.finished_key => true }
finshed_session = session[:split].dup
ab_test('link_color', 'blue', 'red')
session[:split].should eql(finshed_session)
end
end

describe 'finished' do
Expand Down